Closed Bug 1378949 Opened 7 years ago Closed 7 years ago

Intermittent dom/workers/test/serviceworkers/test_notificationclick_focus.html | Test timed out.

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: asuth)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:race])

Attachments

(1 file)

Priority: -- → P5
Andrew, this (and other similar bugs a la bug 1379401) is really frequent on trunk and basically permafailing on Windows on my 57-as-Beta uplift simulations. I'm going to have to skip these tests if we can't get to the bottom of them soon. Can you please take a look?
Flags: needinfo?(bugmail)
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
See Also: → 1321181
Priority: -- → P2
Bug 1378949 found test_notificationclick_focus.html timing out because the
ServiceWorker activation raced the creation of an iframe document that wanted
to be controlled by the serviceworker.

The documents that wanted to be controlled had a half-hearted attempt at
dealing with this by using navigator.serviceWorker.ready, but that would only
work if the SW's attempted to claim the clients if they already existed, which
they did not.

This patch cleans up the defective test and its sibling tests that follow the
same idioms.
Attachment #8908770 - Flags: review?(bkelly)
Comment on attachment 8908770 [details] [diff] [review]
Fix SW notification tests that assumed activated SW to wait for activation

Review of attachment 8908770 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  Sorry I missed this in my previous cleanup of these tests.
Attachment #8908770 - Flags: review?(bkelly) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/9eea474dfa80304f40f9c12c277e9c731da744cc
Bug 1378949 - Fix SW notification tests that assumed activated SW to wait for activation. r=bkelly
Blocks: 1379401
https://hg.mozilla.org/mozilla-central/rev/9eea474dfa80
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Whiteboard: [stockwell needswork:owner] → [stockwell fixed:race]
Blocks: 1398009
Flags: needinfo?(bugmail)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: