Closed
Bug 1378949
Opened 7 years ago
Closed 7 years ago
Intermittent dom/workers/test/serviceworkers/test_notificationclick_focus.html | Test timed out.
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: asuth)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:race])
Attachments
(1 file)
7.71 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=112270702&repo=autoland https://queue.taskcluster.net/v1/task/eXcfU_orQFqGDpNyj-DwqQ/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Priority: -- → P5
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 6•7 years ago
|
||
Andrew, this (and other similar bugs a la bug 1379401) is really frequent on trunk and basically permafailing on Windows on my 57-as-Beta uplift simulations. I'm going to have to skip these tests if we can't get to the bottom of them soon. Can you please take a look?
Flags: needinfo?(bugmail)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bugmail
Status: NEW → ASSIGNED
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Comment 9•7 years ago
|
||
Bug 1378949 found test_notificationclick_focus.html timing out because the ServiceWorker activation raced the creation of an iframe document that wanted to be controlled by the serviceworker. The documents that wanted to be controlled had a half-hearted attempt at dealing with this by using navigator.serviceWorker.ready, but that would only work if the SW's attempted to claim the clients if they already existed, which they did not. This patch cleans up the defective test and its sibling tests that follow the same idioms.
Attachment #8908770 -
Flags: review?(bkelly)
Comment 10•7 years ago
|
||
Comment on attachment 8908770 [details] [diff] [review] Fix SW notification tests that assumed activated SW to wait for activation Review of attachment 8908770 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Sorry I missed this in my previous cleanup of these tests.
Attachment #8908770 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 11•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9eea474dfa80304f40f9c12c277e9c731da744cc Bug 1378949 - Fix SW notification tests that assumed activated SW to wait for activation. r=bkelly
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9eea474dfa80
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell needswork:owner] → [stockwell fixed:race]
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(bugmail)
You need to log in
before you can comment on or make changes to this bug.
Description
•