Closed
Bug 1378962
Opened 7 years ago
Closed 7 years ago
Actions UI should make it clear that triggering is not permitted because the user is not logged in
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
Details
Attachments
(1 file)
Currently the "trigger" button is grayed out with no useful information as to why -- I had to read the source to figure it out.
Assignee | ||
Comment 1•7 years ago
|
||
Hm, I see that it does have a hover text. Still, that wasn't clear, so I'll see if I can do a bit better.
Assignee | ||
Comment 2•7 years ago
|
||
https://github.com/mozilla/treeherder/pull/2628
Comment 3•7 years ago
|
||
Updated•7 years ago
|
Attachment #8885830 -
Flags: review?(cdawson)
Comment 4•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/20ce969eedd49fc7f3584b67c6897054e0c08fd3 Bug 1378962: don't show the 'Trigger' button when not logged in (#2628)
Comment 5•7 years ago
|
||
Comment on attachment 8885830 [details] [review] [treeherder] djmitche:bug1378962 > mozilla:master OK, I'm late getting this done, but thanks to wlach for his review. Looking at this retroactively, it all looks good to me. :) Sorry for the delay. I was on PTO the last two days of last week and just didn't get to it beforehand.
Attachment #8885830 -
Flags: review?(cdawson) → review+
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•