Closed Bug 1378965 Opened 2 years ago Closed 2 years ago

silently include codegen.pp for DOM bindings

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

codegen.pp isn't available immediately (there's a rule to generate it),
and so make warns when it's initially not found.  But since this is a
depends file, like other dependency files generated by the build
process, we should silently include it so make doesn't even warn about
it.
Note that we do the same thing for MDDEPEND_FILES in rules.mk.
Attachment #8884054 - Flags: review?(cmanchester)
Comment on attachment 8884054 [details] [diff] [review]
silently include codegen.pp for DOM bindings

Review of attachment 8884054 [details] [diff] [review]:
-----------------------------------------------------------------

I /think/ this will be safe. There's probably a better way to handle this. But meh.
Attachment #8884054 - Flags: review?(cmanchester) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67f6a4e27d5d
silently include codegen.pp for DOM bindings; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/67f6a4e27d5d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.