1379016 - about:devtools-toolbox displays a blank page

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Benjamin Beurdouche (do not use this account)]

about:about mentions about:devtools-toolbox but it is displaying a blank page

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It needs a query string.  Probably should be hidden from about:about.

Comment 2

[Patrick Brosset <:pbro>]

Alex, any recommendation for this?

Comment 3

[Benjamin Beurdouche (do not use this account)]

This seems now fixed in Nightly, will close very soon if no objections

Comment 4

[Alexandre Poirot [:ochameau]]

It is still visible, and yes we should propably hide it from about:about.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1379016 - Hide about:devtools-toolbox from about:about.

Review commit: https://reviewboard.mozilla.org/r/172048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172048/

Comment 6

[Alexandre Poirot [:ochameau]]

Comment on attachment 8900642 [details]
Bug 1379016 - Hide about:devtools-toolbox from about:about.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172048/diff/1-2/

Comment 7

[Patrick Brosset <:pbro>]

Comment on attachment 8900642 [details]
Bug 1379016 - Hide about:devtools-toolbox from about:about.

https://reviewboard.mozilla.org/r/172048/#review178482

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d457d3406d9d
Hide about:devtools-toolbox from about:about. r=pbro

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d457d3406d9d

Comment 10

[Azmina]

I have reproduced this bug with Nightly 56.0a1 (2017-07-06) on Windows 8.1, 64 Bit!

This bug's fix is verified on Latest Nightly 57.0a1.

Build ID :  20170910100150
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 11

[Md Maruf Rahman]

I have reproduced this Bug with Nightly Nightly 56.0a1 (2017-07-06) (64-bit) on Ubuntu 16.04 LTS!

The bug's fix is now verified on latest Nightly!

Build ID :   20170921100141
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

[bugday-20170920]