1379030 - Audio controls in <video> now expands heightwise to obscure captions and poster image

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Mardeg]

STR: Open testcase link in URL field and click on play button.

In order to display captions by default when playing an audio file, a <video> tag must be used. Doing this also means a URL for the poster attribute can be added (and changed throughout playback). These were both visible unobscured by the audio controls on Nightly builds up until the last 1-3 days.

I suspect the regression is caused by either bug 1367868 or bug 1373537.

Comment 1

[Ray Lin[:ralin]]

Since it's likely my patch causes the regression, NI myself and I'll look more next week. Thanks Mardeg.

Comment 2

[Ray Lin[:ralin]]

Attachment: Bug 1379030 - Only set calculated size to controlbar for audio element since audio-only video has already had given size from layout.

Review commit: https://reviewboard.mozilla.org/r/155572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155572/

Comment 3

[Ray Lin[:ralin]]

Hi Jared,

Could you help me to review this patch? Thanks.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8884703 [details]
Bug 1379030 - Only set calculated size to controlbar for audio element since audio-only video has already had given size from layout.

https://reviewboard.mozilla.org/r/155572/#review160694

Comment 5

[Ray Lin[:ralin]]

Thanks :D

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad99094c54de
Only set calculated size to controlbar for audio element since audio-only video has already had given size from layout. r=jaws

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad99094c54de

Comment 8

[Ray Lin[:ralin]]

Since Bug 1373537 is uplifted to 55, we'll need to uplift as well.

Comment 9

[Ray Lin[:ralin]]

Comment on attachment 8884703 [details]
Bug 1379030 - Only set calculated size to controlbar for audio element since audio-only video has already had given size from layout.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1373537
[User impact if declined]: incorrect media controls layout would present while playing audio-only video.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low
[Why is the change risky/not risky?]: one-liner patch, only get rid of the size adjustment for audio-only <video>
[String changes made/needed]: none


Thank you :D

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

(In reply to Ray Lin[:ralin] from comment #8)
> Since Bug 1373537 is uplifted to 55, we'll need to uplift as well.

FWIW it would have been helpful to point that out in bug 1373537 directly (either in your uplift request, or by making that bug depend on this one), or both.

Comment 11

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8884703 [details]
Bug 1379030 - Only set calculated size to controlbar for audio element since audio-only video has already had given size from layout.

followup fix for bug 1373537, beta55+

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dd69b5e4a722

Comment 13

[Ray Lin[:ralin]]

(In reply to Julien Cristau [:jcristau] from comment #10)
> FWIW it would have been helpful to point that out in bug 1373537 directly
> (either in your uplift request, or by making that bug depend on this one),
> or both.
I'll pay attention to that next time.

Thank you for the help Julien, :Tomcat!