Remove CompositorBridgeParentBase::GetAnimationStorage()

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
This is a follow up of Bug 1376896 Comment 14.
(Assignee)

Updated

a year ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

a year ago
Created attachment 8884134 [details] [diff] [review]
patch - Remove CompositorBridgeParentBase::GetAnimationStorage()
(Assignee)

Updated

a year ago
Attachment #8884134 - Flags: review?(bugmail)
Comment on attachment 8884134 [details] [diff] [review]
patch - Remove CompositorBridgeParentBase::GetAnimationStorage()

Review of attachment 8884134 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorBridgeParent.h
@@ +236,5 @@
>                                   const TimeStamp& aTime) override;
>    virtual void LeaveTestMode(const uint64_t& aId) override;
>    virtual void ApplyAsyncProperties(LayerTransactionParent* aLayerTree)
>                 override;
> +  virtual CompositorAnimationStorage* GetAnimationStorage();

Doesn't need to be virtual
Attachment #8884134 - Flags: review?(bugmail) → review+
(Assignee)

Comment 4

a year ago
Created attachment 8884686 [details] [diff] [review]
patch - Remove CompositorBridgeParentBase::GetAnimationStorage()

Applied the comment.
Attachment #8884134 - Attachment is obsolete: true
Attachment #8884686 - Flags: review+

Comment 5

a year ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e31c78c123a
Remove CompositorBridgeParentBase::GetAnimationStorage() r=kats

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7e31c78c123a
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.