Closed Bug 1379033 Opened 7 years ago Closed 7 years ago

Remove CompositorBridgeParentBase::GetAnimationStorage()

Categories

(Core :: Graphics: Layers, enhancement)

Product:
Core
Component:
Graphics: Layers
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

Details

Attachments

(1 file, 1 obsolete file)

patch - Remove CompositorBridgeParentBase::GetAnimationStorage()
12.65 KB, patch
sotaro
: review+
Details | Diff | Splinter Review 
This is a follow up of Bug 1376896 Comment 14.
Assignee: nobody → sotaro.ikeda.g
Attachment #8884134 - Flags: review?(bugmail)
Comment on attachment 8884134 [details] [diff] [review]
patch - Remove CompositorBridgeParentBase::GetAnimationStorage()

Review of attachment 8884134 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorBridgeParent.h
@@ +236,5 @@
>                                   const TimeStamp& aTime) override;
>    virtual void LeaveTestMode(const uint64_t& aId) override;
>    virtual void ApplyAsyncProperties(LayerTransactionParent* aLayerTree)
>                 override;
> +  virtual CompositorAnimationStorage* GetAnimationStorage();

Doesn't need to be virtual
Attachment #8884134 - Flags: review?(bugmail) → review+
Applied the comment.
Attachment #8884134 - Attachment is obsolete: true
Attachment #8884686 - Flags: review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e31c78c123a
Remove CompositorBridgeParentBase::GetAnimationStorage() r=kats
https://hg.mozilla.org/mozilla-central/rev/7e31c78c123a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: