1379088 - Memory regression on 55 involving Private Tab addon

Status: RESOLVED WONTFIX

(Firefox :: Extension Compatibility, defect)

Description

[Caspy7]

In the past couple of days I've seen two notable reports of memory leaking and poor performance due to the Private Tab addon.

I tested on fresh profiles in 55 and 54.
I simply opened this page and let it sit:
https://ww2.gogoanime.io/hajime-no-ippo--episode-62

The memory begins to climb on both of them, but on 55 it is substantially more. It seems there is a leak associated with the addon, however this could indicate a change that will lead to greater memory usage in some situations in 55+.

The Private Tab addon last saw an update in May:
https://addons.mozilla.org/en-US/firefox/addon/private-tab/versions/

One reporter was on reddit, here is their post 
https://www.reddit.com/r/firefox/comments/6ljuqq/7517_nightly_sucks_up_20gb_while_idling_on_viki/
They indicated they were idling on their [Rakuten] "Viki" watchlist which sounds like some sort of video streaming site - but indicated they were not watching videos. They're on 56 Nightly.

The other user was reported on IRC (Freenode, so there's no log) and was on 55. Indicated they though it started around b4. They associated it with video playback, however they provided me with the link I shared and I could reproduce without playing the video (though it may have just been buffering the whole time).

Comment 1

[:Gijs (away/busy until Mar 10)]

(In reply to Caspy7 from comment #0)
> In the past couple of days I've seen two notable reports of memory leaking
> and poor performance due to the Private Tab addon.
> 
> I tested on fresh profiles in 55 and 54.
> I simply opened this page and let it sit:
> https://ww2.gogoanime.io/hajime-no-ippo--episode-62
> 
> The memory begins to climb on both of them, but on 55 it is substantially
> more. It seems there is a leak associated with the addon, however this could
> indicate a change that will lead to greater memory usage in some situations
> in 55+.

Can you find a regression window using mozregression? You can create a separate clean profile on 54 with the add-on and then use that with mozregression.

Comment 2

[Caspy7]

I don't know if I'll have the capacity to do that today, but I did load that page and run the video for the same amount of time in both 54 & 55 and create memory reports (55 is substantially higher memory usage).
I'll upload these reports in case they can be helpful.

Comment 3

[Caspy7]

Attachment: Release (54) Memory Report

Comment 4

[Caspy7]

Attachment: Beta (55) Memory Report

Comment 5

[u554753]

Please correct if this isn't the right component.

Comment 6

[Andy McKay]

Given that Private Tab won't work in Firefox 57, marking this as won't fix for 57 and we may as well close the bug.

Comment 7

[:Gijs (away/busy until Mar 10)]

Closing per comment #6.