1379108 - Factor GetValidationMessage() out of HTMLInputElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8884721 [details] [diff] [review]
patch, v1.

Always {} with 'if', not if (NS_FAILED(rv)) return rv;

Comment 3

[Jessica Jong [:jessica] (inactive)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8884721 [details] [diff] [review]
> patch, v1.
> 
> Always {} with 'if', not if (NS_FAILED(rv)) return rv;

Noted, thanks.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v2.

Use {} with 'if'. Carrying r+.

Comment 5

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23c4cb8be54429a4b6113277887ac75b83133411&group_state=expanded

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80a55d593115
Factor GetValidationMessage() out of HTMLInputElement. r=smaug

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80a55d593115

Comment 8

[Ton [:Tonnes]]

(In reply to Carsten Book [:Tomcat] from comment #7)
> https://hg.mozilla.org/mozilla-central/rev/80a55d593115

Nit: I’m afraid the comments for the 2 new strings match their new entities.

Comment 9

[Jessica Jong [:jessica] (inactive)]

Oh, right, I forgot to change the name in the comment. :(
I can do that in a followup patch, thanks.

Comment 10

[Jessica Jong [:jessica] (inactive)]

Attachment: (followup) Fix localization notes

comment only, so setting r+ directly.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff468ed8e5a4
(followup) Fix localization notes for FormValidationDateTimeRangeOverflow/Underflow strings. comment-only, DONTBUILD

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff468ed8e5a4

Comment 13

[Stefan Plewako [:stef]]

Do we win anything by not having separate date and time error strings? (at least in Polish this makes them much worse)

Comment 14

[Jessica Jong [:jessica] (inactive)]

(In reply to Stefan Plewako [:stef] from comment #13)
> Do we win anything by not having separate date and time error strings? (at
> least in Polish this makes them much worse)

Oh, I merged them so that I can have only one piece of code in "DateTimeInputTypeBase". I wasn't aware that they use different string in other languages, my bad, do you need me to separate them again?

Comment 15

[Stefan Plewako [:stef]]

https://hg.mozilla.org/mozilla-central/diff/80a55d593115/dom/locales/en-US/chrome/dom/dom.properties
https://github.com/aviarypl/mozilla-l10n-pl/commit/14291a82991ff905eb3bf0c76ba7a9fa58c95588

In Polish we had sth like "Please select a date/time that is no later/earlier than %S." that seems less generic than "value" and could be more easily understandable. Not sure how that compares in English and other locales.