If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make x and y dimensions default to -x- instead of undefinedxundefined

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: miker, Assigned: gl)

Tracking

(Blocks: 1 bug)

51 Branch
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

When the box model is loading it's dimensions very briefly read undefinedxundefined. These values should default to 0x0.

Filter on EdgarMallory
(Assignee)

Updated

2 months ago
Assignee: nobody → gl
Status: NEW → ASSIGNED
(Assignee)

Updated

2 months ago
Summary: Make x and y dimensions default to 0x0 instead of undefinedxundefined → Make x and y dimensions default to -x- instead of undefinedxundefined
(Assignee)

Comment 1

2 months ago
I am setting the default to -x- instead since that's what we currently do in the box model.
(Assignee)

Comment 2

2 months ago
Created attachment 8889888 [details] [diff] [review]
1379109.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f802da570f7ecb46a4c44d9d530f1c7451cbb89
Attachment #8889888 - Flags: review?(tigleym)

Comment 3

2 months ago
Comment on attachment 8889888 [details] [diff] [review]
1379109.patch

Review of attachment 8889888 [details] [diff] [review]:
-----------------------------------------------------------------

Verified that if the height/width values off the boxModel.layout prop is undefined in BoxModelInfo component, it shows "-x-" instead.

Also the same for the layout value off the boxModel prop in BoxModelMain component.
Attachment #8889888 - Flags: review?(tigleym)
Attachment #8889888 - Flags: review+

Comment 4

2 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ede5d14ffb1
Make x and y dimensions default to -x- instead of undefined x undefined. r=micah

Comment 5

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4ede5d14ffb1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.