Closed Bug 1379109 Opened 7 years ago Closed 7 years ago

Make x and y dimensions default to -x- instead of undefinedxundefined

Categories

(DevTools :: Inspector, enhancement)

51 Branch
enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: miker, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When the box model is loading it's dimensions very briefly read undefinedxundefined. These values should default to 0x0.

Filter on EdgarMallory
Assignee: nobody → gl
Status: NEW → ASSIGNED
Summary: Make x and y dimensions default to 0x0 instead of undefinedxundefined → Make x and y dimensions default to -x- instead of undefinedxundefined
I am setting the default to -x- instead since that's what we currently do in the box model.
Comment on attachment 8889888 [details] [diff] [review]
1379109.patch

Review of attachment 8889888 [details] [diff] [review]:
-----------------------------------------------------------------

Verified that if the height/width values off the boxModel.layout prop is undefined in BoxModelInfo component, it shows "-x-" instead.

Also the same for the layout value off the boxModel prop in BoxModelMain component.
Attachment #8889888 - Flags: review?(tigleym)
Attachment #8889888 - Flags: review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ede5d14ffb1
Make x and y dimensions default to -x- instead of undefined x undefined. r=micah
https://hg.mozilla.org/mozilla-central/rev/4ede5d14ffb1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.