1379109 - Make x and y dimensions default to -x- instead of undefinedxundefined

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

When the box model is loading it's dimensions very briefly read undefinedxundefined. These values should default to 0x0.

Filter on EdgarMallory

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

I am setting the default to -x- instead since that's what we currently do in the box model.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1379109.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f802da570f7ecb46a4c44d9d530f1c7451cbb89

Comment 3

[Micah Tigley [:micah]]

Comment on attachment 8889888 [details] [diff] [review]
1379109.patch

Review of attachment 8889888 [details] [diff] [review]:
-----------------------------------------------------------------

Verified that if the height/width values off the boxModel.layout prop is undefined in BoxModelInfo component, it shows "-x-" instead.

Also the same for the layout value off the boxModel prop in BoxModelMain component.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ede5d14ffb1
Make x and y dimensions default to -x- instead of undefined x undefined. r=micah

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ede5d14ffb1