Closed
Bug 1379109
Opened 7 years ago
Closed 7 years ago
Make x and y dimensions default to -x- instead of undefinedxundefined
Categories
(DevTools :: Inspector, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: miker, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
2.50 KB,
patch
|
micah
:
review+
micah
:
review+
|
Details | Diff | Splinter Review |
When the box model is loading it's dimensions very briefly read undefinedxundefined. These values should default to 0x0. Filter on EdgarMallory
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gl
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Summary: Make x and y dimensions default to 0x0 instead of undefinedxundefined → Make x and y dimensions default to -x- instead of undefinedxundefined
Assignee | ||
Comment 1•7 years ago
|
||
I am setting the default to -x- instead since that's what we currently do in the box model.
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f802da570f7ecb46a4c44d9d530f1c7451cbb89
Attachment #8889888 -
Flags: review?(tigleym)
Comment 3•7 years ago
|
||
Comment on attachment 8889888 [details] [diff] [review] 1379109.patch Review of attachment 8889888 [details] [diff] [review]: ----------------------------------------------------------------- Verified that if the height/width values off the boxModel.layout prop is undefined in BoxModelInfo component, it shows "-x-" instead. Also the same for the layout value off the boxModel prop in BoxModelMain component.
Attachment #8889888 -
Flags: review?(tigleym)
Attachment #8889888 -
Flags: review+
Pushed by gabriel.luong@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4ede5d14ffb1 Make x and y dimensions default to -x- instead of undefined x undefined. r=micah
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4ede5d14ffb1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•