InstallTrigger.InstallChrome fails on when url contains query string (windows only)

NEW
Unassigned

Status

Core Graveyard
Installer: XPInstall Engine
16 years ago
2 years ago

People

(Reporter: dprice (gone), Unassigned)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

16 years ago
nsXPInstallManager::GetDestinationFile() returns invalid filenames when a chrome
install is triggered from a url with a query string.  

The fix for the non chrome case is to simply default the destination file to
tmp.xpi.  In the case of chrome we'd like to have a meaningful filename because
it stays around when the install is completed.  This means finding the ? in the
string and truncating after that point.  We'll have to worry about unicode and
mulitbyte problems (we don't want to find the ? in the second btye)

see 130428 for the non-chrome case

Updated

12 years ago
Assignee: dprice → xpi-engine
OS: Windows 2000 → Windows XP
QA Contact: jimmykenlee
Since this bug hasn't been updated in over 4 years, I just thought I'd mention where the flood of CC's is coming from and that it definitely still exists. We ran into this problem on AMO today (bug 351511). We previously used "approvalfile.php/extension.xpi" as the download and InstallTrigger path for the addon approval queue. We attempted to change this to "approvalfile.php?file=extension.xpi", and this worked fine for the extensions, but themes wouldn't install from it and only on Windows.

I finally found this bug that described our exact problem and we'll be reverting back to the slash format.
Assignee: xpi-engine → nobody
QA Contact: xpi-engine
(Assignee)

Updated

2 years ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.