1379116 - Addon install error string is not localized

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Attachment: aboutdebugging_addon_install_error.png

The following string is hardcoded in enlish in about:debugging while the rest of the UI is localized.

http://searchfox.org/mozilla-central/rev/f1472e5b57fea8d4a7bbdd81c44e46958fe3c1ce/devtools/client/aboutdebugging/components/addons/install-error.js#21

This string is displayed when an addon fails to install via about:debugging.

Comment 1

[Julian Descottes [:jdescottes]]

Alex, this string was introduced in Bug 1231128. Looking at the bug I don't see localization being mentioned, but maybe it was intentional to keep the string in english since the error message displayed right after is in english?

I guess we should either add a comment to make it explicit, or localize the string. What do you think?

Comment 2

[Alexandre Poirot [:ochameau]]

(In reply to Julian Descottes [:jdescottes][:julian] from comment #1)
> Alex, this string was introduced in Bug 1231128. Looking at the bug I don't
> see localization being mentioned, but maybe it was intentional to keep the
> string in english since the error message displayed right after is in
> english?

Sorry for never replying, I loose track of ni? after a while.

> I guess we should either add a comment to make it explicit, or localize the
> string. What do you think?

Not translating it wasn't intentional.
Either way, I don't have any strong opinion on this.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1379116 - Localize hardcoded addon installation error string in about:debugging;

Review commit: https://reviewboard.mozilla.org/r/237164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237164/

Comment 4

[Julian Descottes [:jdescottes]]

(In reply to Alexandre Poirot [:ochameau] from comment #2)
> (In reply to Julian Descottes [:jdescottes][:julian] from comment #1)
> > Alex, this string was introduced in Bug 1231128. Looking at the bug I don't
> > see localization being mentioned, but maybe it was intentional to keep the
> > string in english since the error message displayed right after is in
> > english?
> 
> Sorry for never replying, I loose track of ni? after a while.
> 

Don't worry I'm just doing a mass cleanup of old needinfos :)

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8968454 [details]
Bug 1379116 - Localize hardcoded addon installation error string in about:debugging;

https://reviewboard.mozilla.org/r/237164/#review242970

Thanks Julian.

May be the localization key would be better with singular: addonInstallError?

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8968454 [details]
Bug 1379116 - Localize hardcoded addon installation error string in about:debugging;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237164/diff/1-2/

Comment 7

[Julian Descottes [:jdescottes]]

(In reply to Alexandre Poirot [:ochameau] from comment #5)
> Comment on attachment 8968454 [details]
> Bug 1379116 - Localize hardcoded addon installation error string in
> about:debugging;
> 
> https://reviewboard.mozilla.org/r/237164/#review242970
> 
> Thanks Julian.
> 
> May be the localization key would be better with singular: addonInstallError?

Sure, updated! 
Thanks for the review Alex.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4816cf388e26
Localize hardcoded addon installation error string in about:debugging;r=ochameau

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4816cf388e26