Closed
Bug 1379116
Opened 8 years ago
Closed 7 years ago
Addon install error string is not localized
Categories
(DevTools :: about:debugging, enhancement, P3)
DevTools
about:debugging
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
Details
Attachments
(2 files)
The following string is hardcoded in enlish in about:debugging while the rest of the UI is localized.
http://searchfox.org/mozilla-central/rev/f1472e5b57fea8d4a7bbdd81c44e46958fe3c1ce/devtools/client/aboutdebugging/components/addons/install-error.js#21
This string is displayed when an addon fails to install via about:debugging.
Assignee | ||
Comment 1•8 years ago
|
||
Alex, this string was introduced in Bug 1231128. Looking at the bug I don't see localization being mentioned, but maybe it was intentional to keep the string in english since the error message displayed right after is in english?
I guess we should either add a comment to make it explicit, or localize the string. What do you think?
Flags: needinfo?(poirot.alex)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(poirot.alex)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
(In reply to Julian Descottes [:jdescottes][:julian] from comment #1)
> Alex, this string was introduced in Bug 1231128. Looking at the bug I don't
> see localization being mentioned, but maybe it was intentional to keep the
> string in english since the error message displayed right after is in
> english?
Sorry for never replying, I loose track of ni? after a while.
> I guess we should either add a comment to make it explicit, or localize the
> string. What do you think?
Not translating it wasn't intentional.
Either way, I don't have any strong opinion on this.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Alexandre Poirot [:ochameau] from comment #2)
> (In reply to Julian Descottes [:jdescottes][:julian] from comment #1)
> > Alex, this string was introduced in Bug 1231128. Looking at the bug I don't
> > see localization being mentioned, but maybe it was intentional to keep the
> > string in english since the error message displayed right after is in
> > english?
>
> Sorry for never replying, I loose track of ni? after a while.
>
Don't worry I'm just doing a mass cleanup of old needinfos :)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8968454 [details]
Bug 1379116 - Localize hardcoded addon installation error string in about:debugging;
https://reviewboard.mozilla.org/r/237164/#review242970
Thanks Julian.
May be the localization key would be better with singular: addonInstallError?
Attachment #8968454 -
Flags: review?(poirot.alex) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
(In reply to Alexandre Poirot [:ochameau] from comment #5)
> Comment on attachment 8968454 [details]
> Bug 1379116 - Localize hardcoded addon installation error string in
> about:debugging;
>
> https://reviewboard.mozilla.org/r/237164/#review242970
>
> Thanks Julian.
>
> May be the localization key would be better with singular: addonInstallError?
Sure, updated!
Thanks for the review Alex.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4816cf388e26
Localize hardcoded addon installation error string in about:debugging;r=ochameau
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•