1379143 - Get rid of makeURI and makeFileURI

Status: NEW

(Firefox :: General, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

makeURI (https://searchfox.org/mozilla-central/search?q=makeURI) and its less popular cousin makeFileURI (https://searchfox.org/mozilla-central/search?q=makeFileURI) are, in most cases, unnecessary overhead that is re-declared in a dozen modules despite no clear disadvantage over just using Services.io.newURI (since bug 1329182 landed).

In the case of browser.js specifically, it's hard to find out where the global makeURI function is defined (https://searchfox.org/mozilla-central/source/toolkit/content/contentAreaUtils.js#944).

I vote for getting rid of the overhead.

Unfortunately it seems like we need to wait for 57 to come around to avoid breaking add-ons.

Comment 1

[Florian Quèze [:florian]]

I would also be happy to see the NetUtil.newURI cousin go away: http://searchfox.org/mozilla-central/search?q=netutil.newuri

Comment 2

[Joe Hildebrand [:jhildebrand] (UTC-6)]

Get this added to the technical debt list, please.  Talk to mossop for a pointer.

Comment 3

[Florian Quèze [:florian]]

(In reply to Joe Hildebrand  [:hildjj] (UTC-6) from comment #2)
> Get this added to the technical debt list, please.  Talk to mossop for a
> pointer.

Comment 4

[Dave Townsend [:mossop]]

Added

Comment 5

[shruti10gandotra]

Please assign this to me

Comment 6

[Monika Maheshwari [:MonikaMaheshwari]]

Hey, Can I work on this issue?

Comment 7

[Johann Hofmann [:johannh]]

This isn't really a good bug for a contributor to tackle (it's a lot to rewrite). If you really want to work on this issue, I would recommend filing bugs for replacing usage in individual files like we've done so far or coming up with some sort of automated rewrite. In any case I won't assign anyone to this without a patch :)