Get rid of makeURI and makeFileURI

NEW
Unassigned

Status

()

enhancement
P3
normal
2 years ago
a month ago

People

(Reporter: johannh, Unassigned)

Tracking

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix)

Details

(Reporter)

Description

2 years ago
makeURI (https://searchfox.org/mozilla-central/search?q=makeURI) and its less popular cousin makeFileURI (https://searchfox.org/mozilla-central/search?q=makeFileURI) are, in most cases, unnecessary overhead that is re-declared in a dozen modules despite no clear disadvantage over just using Services.io.newURI (since bug 1329182 landed).

In the case of browser.js specifically, it's hard to find out where the global makeURI function is defined (https://searchfox.org/mozilla-central/source/toolkit/content/contentAreaUtils.js#944).

I vote for getting rid of the overhead.

Unfortunately it seems like we need to wait for 57 to come around to avoid breaking add-ons.
I would also be happy to see the NetUtil.newURI cousin go away: http://searchfox.org/mozilla-central/search?q=netutil.newuri
Get this added to the technical debt list, please.  Talk to mossop for a pointer.
Priority: -- → P3
(In reply to Joe Hildebrand  [:hildjj] (UTC-6) from comment #2)
> Get this added to the technical debt list, please.  Talk to mossop for a
> pointer.
Flags: needinfo?(dtownsend)
Added
Flags: needinfo?(dtownsend)
(Reporter)

Updated

a year ago
Depends on: 1353536
(Reporter)

Updated

a year ago
Depends on: 1445895
(Reporter)

Updated

8 months ago
Depends on: 1486313
(Reporter)

Updated

2 months ago
Depends on: 1531008
(Reporter)

Updated

2 months ago
Depends on: 1531013

Comment 5

2 months ago

Please assign this to me

Hey, Can I work on this issue?

(Reporter)

Comment 7

a month ago

This isn't really a good bug for a contributor to tackle (it's a lot to rewrite). If you really want to work on this issue, I would recommend filing bugs for replacing usage in individual files like we've done so far or coming up with some sort of automated rewrite. In any case I won't assign anyone to this without a patch :)

You need to log in before you can comment on or make changes to this bug.