Remove AndroidDecoderReader

RESOLVED FIXED in Firefox 56

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks 1 bug)

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(3 attachments)

The AndroidDecoderReader is no longer maintained and is dragging the rest of the playback architecture back.

This bug will remove it.
Comment on attachment 8886361 [details]
Bug 1379190: P1. Remove AndroidMediaDecoder and relatives.

https://reviewboard.mozilla.org/r/157104/#review162276
Attachment #8886361 - Flags: review?(cpearce) → review+
Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

https://reviewboard.mozilla.org/r/157106/#review162278

::: commit-message-b16b7:3
(Diff revision 1)
> +Bug 1379190: P2. Remove OMX related config. r?cpearce
> +
> +They are no longer used.

Although this is trivial, I think a build peer should review this.
Comment on attachment 8886363 [details]
Bug 1379190: P3. Remove omx-plugin 3rd party libs.

https://reviewboard.mozilla.org/r/157108/#review162280
Attachment #8886363 - Flags: review?(cpearce) → review+
Attachment #8886362 - Flags: review?(cpearce) → review?(mh+mozilla)
Duplicate of this bug: 1378666
Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

https://reviewboard.mozilla.org/r/157106/#review163198

You need to remove the options from build/moz.configure/old.configure
Attachment #8886362 - Flags: review?(mh+mozilla)
Attachment #8886362 - Flags: review?(cpearce)
Attachment #8886362 - Flags: review?(mh+mozilla)
Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

https://reviewboard.mozilla.org/r/157106/#review163386

::: build/moz.configure/old.configure
(Diff revision 2)
>      '--cache-file',
>      '--datadir',
>      '--enable-accessibility',
>      '--enable-address-sanitizer',
>      '--enable-alsa',
> -    '--enable-android-omx',

BTW, didn't the build fail without this change? If not, would you mind filing a bug, because it really should have.
Attachment #8886362 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

https://reviewboard.mozilla.org/r/157106/#review163386

> BTW, didn't the build fail without this change? If not, would you mind filing a bug, because it really should have.

no it didn't.

not locally, and not on try. The one failure on try I got was related to the try build syntax generating options not recognised:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc797627cc4224954192da6bbd4a39a8216e5337
"
Exception: Unknown platform(s) [android-api-15-frontend,android-api-15-gradle-dependencies] specified for try [log…] "
Blocks: 1381763
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef8efcab8e8e
P1. Remove AndroidMediaDecoder and relatives. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/9481526ab4e1
P2. Remove OMX related config. r=glandium
https://hg.mozilla.org/integration/autoland/rev/1f7435a8c0d5
P3. Remove omx-plugin 3rd party libs. r=cpearce
This removed a noticeable amount of compiler warnings. Thank you!

== Change summary for alert #8032 (as of July 18 2017 09:24 UTC) ==

Improvements:

 15%  compiler warnings summary android-4-0-armv7-api15 debug      520.42 -> 443.00
  6%  compiler warnings summary android-4-2-x86 opt                1,261.00 -> 1,183.00
  6%  compiler warnings summary android-api-15-gradle opt          1,269.92 -> 1,191.92
  6%  compiler warnings summary android-4-0-armv7-api15 opt        1,270.00 -> 1,192.00
  6%  compiler warnings summary android-5-0-aarch64 opt            1,293.42 -> 1,215.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8032
Depends on: 1381908
You need to log in before you can comment on or make changes to this bug.