1379190 - Remove AndroidDecoderReader

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Jean-Yves Avenard [:jya]]

The AndroidDecoderReader is no longer maintained and is dragging the rest of the playback architecture back.

This bug will remove it.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1379190: P1. Remove AndroidMediaDecoder and relatives.

They are no longer supported and can't work with API >= 16

Review commit: https://reviewboard.mozilla.org/r/157104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157104/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1379190: P2. Remove OMX related config.

They are no longer used.

Review commit: https://reviewboard.mozilla.org/r/157106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157106/

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1379190: P3. Remove omx-plugin 3rd party libs.

They weren't used on android API < 16.

Review commit: https://reviewboard.mozilla.org/r/157108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157108/

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8886361 [details]
Bug 1379190: P1. Remove AndroidMediaDecoder and relatives.

https://reviewboard.mozilla.org/r/157104/#review162276

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

https://reviewboard.mozilla.org/r/157106/#review162278

::: commit-message-b16b7:3
(Diff revision 1)
> +Bug 1379190: P2. Remove OMX related config. r?cpearce
> +
> +They are no longer used.

Although this is trivial, I think a build peer should review this.

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8886363 [details]
Bug 1379190: P3. Remove omx-plugin 3rd party libs.

https://reviewboard.mozilla.org/r/157108/#review162280

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

https://reviewboard.mozilla.org/r/157106/#review163198

You need to remove the options from build/moz.configure/old.configure

Comment 9

[Jean-Yves Avenard [:jya]]

Comment on attachment 8886361 [details]
Bug 1379190: P1. Remove AndroidMediaDecoder and relatives.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157104/diff/1-2/

Comment 10

[Jean-Yves Avenard [:jya]]

Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157106/diff/1-2/

Comment 11

[Jean-Yves Avenard [:jya]]

Comment on attachment 8886363 [details]
Bug 1379190: P3. Remove omx-plugin 3rd party libs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157108/diff/1-2/

Comment 12

[Mike Hommey [:glandium]]

Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

https://reviewboard.mozilla.org/r/157106/#review163386

::: build/moz.configure/old.configure
(Diff revision 2)
>      '--cache-file',
>      '--datadir',
>      '--enable-accessibility',
>      '--enable-address-sanitizer',
>      '--enable-alsa',
> -    '--enable-android-omx',

BTW, didn't the build fail without this change? If not, would you mind filing a bug, because it really should have.

Comment 13

[Jean-Yves Avenard [:jya]]

Comment on attachment 8886362 [details]
Bug 1379190: P2. Remove OMX related config.

https://reviewboard.mozilla.org/r/157106/#review163386

> BTW, didn't the build fail without this change? If not, would you mind filing a bug, because it really should have.

no it didn't.

not locally, and not on try. The one failure on try I got was related to the try build syntax generating options not recognised:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc797627cc4224954192da6bbd4a39a8216e5337
"
Exception: Unknown platform(s) [android-api-15-frontend,android-api-15-gradle-dependencies] specified for try [log…] "

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef8efcab8e8e
P1. Remove AndroidMediaDecoder and relatives. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/9481526ab4e1
P2. Remove OMX related config. r=glandium
https://hg.mozilla.org/integration/autoland/rev/1f7435a8c0d5
P3. Remove omx-plugin 3rd party libs. r=cpearce

Comment 15

[Ionuț Goldan [:igoldan]]

This removed a noticeable amount of compiler warnings. Thank you!

== Change summary for alert #8032 (as of July 18 2017 09:24 UTC) ==

Improvements:

 15%  compiler warnings summary android-4-0-armv7-api15 debug      520.42 -> 443.00
  6%  compiler warnings summary android-4-2-x86 opt                1,261.00 -> 1,183.00
  6%  compiler warnings summary android-api-15-gradle opt          1,269.92 -> 1,191.92
  6%  compiler warnings summary android-4-0-armv7-api15 opt        1,270.00 -> 1,192.00
  6%  compiler warnings summary android-5-0-aarch64 opt            1,293.42 -> 1,215.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8032

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ef8efcab8e8e
https://hg.mozilla.org/mozilla-central/rev/9481526ab4e1
https://hg.mozilla.org/mozilla-central/rev/1f7435a8c0d5