Closed Bug 1379200 Opened 7 years ago Closed 7 years ago

Intermittent TEST-UNEXPECTED-TIMEOUT | /service-workers/service-worker/update-bytecheck.https.html | Test(cors: true, main: default, imported: time) - Test timed out

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: bhsu)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])

Attachments

(1 file)

Priority: -- → P5
Whiteboard: [stockwell unknown]
we have 38 failures in the last 6 days, I think the automatic report got the perfect set of failures to show <30.

:bkelly, I know you are very knowledgeable about service workers and the web-platform-tests that provide coverage for them.  Can you look into this bug or help find someone to look into it?  I would prefer to resolve this vs disable it in due time.
Flags: needinfo?(bkelly)
Whiteboard: [stockwell unknown] → [stockwell needswork]
I think HoPang recently landed changes to the our update mechanism.  Redirecting NI to him to check it out.
Flags: needinfo?(bkelly) → needinfo?(bhsu)
Sure, I'll check this as well

At this moment, I think this bug shares the same root cause with bug 1391532. As bug 1391532 shows, the imported script is somehow not being upgraded (or maybe just get the same script again with some reasons), so we would find the service workers share the same source and thus are found byte identical, which causes the timeout.
Assignee: nobody → bhsu
Flags: needinfo?(bhsu)
Any updates on this, Ben? I see this really frequently in my 57-as-Beta uplift simulations and will probably resort to disabling the test after the uplift if things don't improve.
Flags: needinfo?(bhsu)
Comment on attachment 8906880 [details] [diff] [review]
Preserve the precision of a timestamp when converting it to string

Sorry Ryan,
I was checking the how the patch for 1391532 works.

Hi Ben,
It seems that a peaceful week has passed, I think we can do the exactly the same thing here. Could you review this?
Flags: needinfo?(bhsu)
Attachment #8906880 - Flags: review?(bkelly)
Attachment #8906880 - Flags: review?(bkelly) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba4c92f6f9f1
Preserve the precision of a timestamp when converting it to string. r=bkelly
https://hg.mozilla.org/mozilla-central/rev/ba4c92f6f9f1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.