Closed
Bug 1379200
Opened 7 years ago
Closed 7 years ago
Intermittent TEST-UNEXPECTED-TIMEOUT | /service-workers/service-worker/update-bytecheck.https.html | Test(cors: true, main: default, imported: time) - Test timed out
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: intermittent-bug-filer, Assigned: bhsu)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell unknown])
Attachments
(1 file)
1.60 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Filed by: archaeopteryx [at] coole-files.de https://treeherder.mozilla.org/logviewer.html#?job_id=112565994&repo=autoland https://queue.taskcluster.net/v1/task/Xau75ekaT2S8LFwTYpwEKA/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Priority: -- → P5
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell unknown]
Comment 8•7 years ago
|
||
we have 38 failures in the last 6 days, I think the automatic report got the perfect set of failures to show <30. :bkelly, I know you are very knowledgeable about service workers and the web-platform-tests that provide coverage for them. Can you look into this bug or help find someone to look into it? I would prefer to resolve this vs disable it in due time.
Flags: needinfo?(bkelly)
Whiteboard: [stockwell unknown] → [stockwell needswork]
Comment 9•7 years ago
|
||
I think HoPang recently landed changes to the our update mechanism. Redirecting NI to him to check it out.
Flags: needinfo?(bkelly) → needinfo?(bhsu)
Assignee | ||
Comment 10•7 years ago
|
||
Sure, I'll check this as well At this moment, I think this bug shares the same root cause with bug 1391532. As bug 1391532 shows, the imported script is somehow not being upgraded (or maybe just get the same script again with some reasons), so we would find the service workers share the same source and thus are found byte identical, which causes the timeout.
Assignee: nobody → bhsu
Flags: needinfo?(bhsu)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 14•7 years ago
|
||
Any updates on this, Ben? I see this really frequently in my 57-as-Beta uplift simulations and will probably resort to disabling the test after the uplift if things don't improve.
Flags: needinfo?(bhsu)
Assignee | ||
Comment 15•7 years ago
|
||
Assignee | ||
Comment 16•7 years ago
|
||
Comment on attachment 8906880 [details] [diff] [review] Preserve the precision of a timestamp when converting it to string Sorry Ryan, I was checking the how the patch for 1391532 works. Hi Ben, It seems that a peaceful week has passed, I think we can do the exactly the same thing here. Could you review this?
Flags: needinfo?(bhsu)
Attachment #8906880 -
Flags: review?(bkelly)
Updated•7 years ago
|
Attachment #8906880 -
Flags: review?(bkelly) → review+
Comment 17•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ba4c92f6f9f1 Preserve the precision of a timestamp when converting it to string. r=bkelly
Comment 18•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ba4c92f6f9f1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 19•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/fc985a161026
status-firefox56:
--- → fixed
Flags: in-testsuite+
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•