1379216 - Don't save a strong reference in HTMLTableElement::Rows()

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[(no longer active)]

This is similar to bug 1377560, although bug 1378201 is making this code not use nsContentLists.  But it would be nice to not have a strong ref here for similar reasons.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

We'd need to make sure that something like this doesn't cause the creation of a new TableRowsCollection:

for (let i = 0; i < table.rows.length; ++i) {
  doSomeWork();
}

I imagine in a situation like this we'd really want to not create a new rows object every iteration (or every few iterations) of the loop, as creating one is expensive. That being said, we also don't want to keep our rows object alive indefinitely. I'm not sure how we can intelligently make a decision about this.

Comment 2

[(no longer active)]

The object is held alive by the cycle collector I believe so it will stay alive during such a loop without us needing to do anything.  But yes it's worth double checking that the assumption indeed holds!

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information