1379254 - MOZ_CRASH_UNSAFE_* should require data review

Status: RESOLVED FIXED

(Core :: MFBT, enhancement, P2)

Description

[Benjamin Smedberg]

The MOZ_CRASH_UNSAFE_* macros were added in bug 1338574 as a way to provide richer crash diagnostics. However, because these aren't using compile-time strings, there is a risk that they could leak privacy-sensitive out through crash-stats. This isn't obvious in the code, and so I'd like to add an explicit comment about it.

(I noticed this while doing the review on bug 1367896.)

Comment 1

[Benjamin Smedberg]

Attachment: Bug 1379254 - Add a @note to the documentation of MOZ_CRASH_UNSAFE_* to make clear data collection risk and requirements,

Review commit: https://reviewboard.mozilla.org/r/155286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155286/

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8884367 [details]
Bug 1379254 - Add a @note to the documentation of MOZ_CRASH_UNSAFE_* to make clear data collection risk and requirements,

https://reviewboard.mozilla.org/r/155286/#review160964

Looks good, you might want to email dev-platform about the requirment as well.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07976bd4a36c
Add a @note to the documentation of MOZ_CRASH_UNSAFE_* to make clear data collection risk and requirements, r=erahm

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/07976bd4a36c