Closed Bug 1379254 Opened 2 years ago Closed 2 years ago

MOZ_CRASH_UNSAFE_* should require data review

Categories

(Core :: MFBT, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: benjamin, Assigned: benjamin)

Details

Attachments

(1 file)

The MOZ_CRASH_UNSAFE_* macros were added in bug 1338574 as a way to provide richer crash diagnostics. However, because these aren't using compile-time strings, there is a risk that they could leak privacy-sensitive out through crash-stats. This isn't obvious in the code, and so I'd like to add an explicit comment about it.

(I noticed this while doing the review on bug 1367896.)
Comment on attachment 8884367 [details]
Bug 1379254 - Add a @note to the documentation of MOZ_CRASH_UNSAFE_* to make clear data collection risk and requirements,

https://reviewboard.mozilla.org/r/155286/#review160964

Looks good, you might want to email dev-platform about the requirment as well.
Attachment #8884367 - Flags: review?(erahm) → review+
Pushed by bsmedberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/07976bd4a36c
Add a @note to the documentation of MOZ_CRASH_UNSAFE_* to make clear data collection risk and requirements, r=erahm
https://hg.mozilla.org/mozilla-central/rev/07976bd4a36c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.