1379268 - Switching between Firefox windows caused tab background color to lag behind titlebar

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Benjamin Smedberg]

Attachment: 2017-07-07-toolbar-color-lag.gif

After bug 1196266, switching between Firefox windows with the mouse causes a pretty serious mismatch between the titlebar and the tab background for a period of time.

Screencast attached.

This is more serious when the titlebar is showing because you can see the delay visually. When the titlebar is off (the default), the delay is still there but Firefox just feels slow rather than showing a visual mismatch.

Comment 1

[Johann Hofmann [:johannh]]

I can't reproduce on my Windows VM, but that doesn't mean other people aren't seeing this. This is a pretty serious problem.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #0)
> This is more serious when the titlebar is showing because you can see the
> delay visually.

The solution here will be to not apply the accent color beyond the title bar when the native title bar is enabled.

> When the titlebar is off (the default), the delay is still
> there but Firefox just feels slow rather than showing a visual mismatch.

There's probably not much we can do about that.

Comment 3

[Benjamin Smedberg]

> There's probably not much we can do about that.

Why not? Can't we at least profile and figure out why focus events aren't coming through very quickly?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Benjamin Smedberg [:bsmedberg] from comment #3)
> > There's probably not much we can do about that.
> 
> Why not? Can't we at least profile and figure out why focus events aren't
> coming through very quickly?

That's of course always a good idea, and people have in fact profiled window activation. Bug 1334642 was filed and fixed as a result. I just suspect there aren't more low-hanging fruits left.

Comment 5

[Markus Stange [:mstange]]

The other option would be to draw the titlebar as part of the Firefox content instead of using the Windows native titlebar. Then the whole window would switch delayed, but at least it would switch at the same time.

Comment 6

[Dão Gottwald [:dao]]

Attachment: Bug 1379268 - Don't apply the accent color beyond the title bar when the native title bar is enabled.

Review commit: https://reviewboard.mozilla.org/r/156132/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156132/

Comment 7

[Johann Hofmann [:johannh]]

I don't understand why we're not using the dark blue background for Photon here. Can you clarify that?

Comment 8

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #7)
> I don't understand why we're not using the dark blue background for Photon
> here. Can you clarify that?

Having two different and dominant colors up there doesn't sound like a good idea to me. It's too colorful and jarring.

Comment 9

[Johann Hofmann [:johannh]]

Comment on attachment 8885263 [details]
Bug 1379268 - Don't apply the accent color beyond the title bar when the native title bar is enabled.

https://reviewboard.mozilla.org/r/156132/#review161546

Ok, to me it sounds like the whole UI concept is getting a bit too colorful/inconsistent if the tab bar is grey, but I don't want to stall on a subjective matter. We can always change the color later.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a426a96fbedb
Don't apply the accent color beyond the title bar when the native title bar is enabled. r=johannh

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a426a96fbedb

Comment 13

[Deac Alin]

Verified on Windows 10 x 64 on the latest Nightly 57.0a1 ID 20170816100153. The issue is not reproducible. I will mark this bug as verified fixed. Thank you