1379269 - Toggling "Show accent color on title bar" in Windows settings is not picked up until restart

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P1)

Description

[Johann Hofmann [:johannh]]

When I check the "Show color in title bar" checkbox in Windows accent color settings I would expect Firefox to instantly change to the Windows accent color (like the settings screen does). It doesn't.

Comment 1

[Johann Hofmann [:johannh]]

Jonathan, can we enable this somehow?

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Note, over in bug 1379173 I get background color changes in the tab strip even though I never enabled accent title colors in windows.

Comment 3

[Johann Hofmann [:johannh]]

(In reply to Ben Kelly [reviewing, but slowly][:bkelly] from comment #2)
> Note, over in bug 1379173 I get background color changes in the tab strip
> even though I never enabled accent title colors in windows.

Yes, that's not unexpected. :)

We can figure out in bug 1379173 if we really want to do it, though.

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: patch

The '-moz-win-accentcolor' keyword is already live to changes to the color that is chosen for the Windows 10 accent color. This patch is required to invalidate the cached result of the '-moz-windows-accent-color-applies' media query when the Windows 10 accent color is enabled/disabled in the Windows settings.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33f7f73ffb36
Make the '-moz-windows-accent-color-applies' media query live to Windows 10 settings changes. r=dholbert

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33f7f73ffb36

Comment 7

[Justin Dolske [:Dolske]]

This doesn't seem to be working for me. In a current (7/20) Nightly, when I enable the Win10 option to show the titlebar accent color, I still have to restart Firefox for it to take effect (otherwise it continues to just show the default Firefox theme). Ditto for disabling the Windows setting (Firefox continues to use the accent color until it is restarted).

The color itself will update w/o a restart when I change it from the Windows dialog.

Comment 8

[Daniel Holbert [:dholbert]]

[I think you meant to needinfo the patch-author, jwatt, who conveniently is back as of today according to his Bugzilla nick.  Transferring ni.]

Comment 9

[Johann Hofmann [:johannh]]

After using this on Windows for a few days it seems like certain actions e.g. minimizing the browser window or opening a new window will cause the setting to apply correctly. We probably need to do out whatever these actions are doing to reset/invalidate the accent color.

Comment 10

[Johann Hofmann [:johannh]]

> need to do out

Sigh, this was originally "find out" but I'm trying to say "we need to do whatever these actions are doing".

Comment 11

[Jonathan Watt [:jwatt]]

Strange. This works for certain windows such as the Browser Console. I'm pretty sure I was just using regular windows when I tested this though.

Comment 12

[Jonathan Watt [:jwatt]]

(In reply to Johann Hofmann [:johannh] from comment #9)
> After using this on Windows for a few days it seems like certain actions
> e.g. minimizing the browser window or opening a new window will cause the
> setting to apply correctly.

When resizing the window etc. causes the visual appearance to correctly refresh we end up getting the media query value under the stack:

  GetSystemMetric
  nsMediaQueryResultCacheKey::Matches
  nsCSSRuleProcessor::RefreshRuleCascade
  nsCSSRuleProcessor::MediumFeaturesChanged
  nsStyleSet::MediumFeaturesChanged
  mozilla::StyleSetHandle::Ptr::MediumFeaturesChanged
  nsPresContext::MediaFeatureValuesChanged
  nsPresContext::FlushPendingMediaFeatureValuesChanged
  mozilla::PresShell::DoFlushPendingNotifications
  nsIPresShell::FlushPendingNotifications
  mozilla::PresShell::DoFlushPendingNotifications
  nsIPresShell::FlushPendingNotifications
  nsDocument::FlushPendingNotifications
  mozilla::dom::BoxObject::GetPresShell
  mozilla::dom::BoxObject::GetFrame
  mozilla::dom::BoxObject::GetOffsetRect
  mozilla::dom::BoxObject::GetWidth
  mozilla::dom::BoxObject::Width
  mozilla::dom::BoxObjectBinding::get_width

It looks like the patch I needed really should be calling nsPresContext::MediaFeatureValuesChanged too.

Comment 13

[Jonathan Watt [:jwatt]]

Attachment: part 2 - Invalidate and notify when clearing cached media features for Windows accent c olor changes

Comment 14

[Daniel Holbert [:dholbert]]

Comment on attachment 8890350 [details] [diff] [review]
part 2 - Invalidate and notify when clearing cached media features for Windows accent c olor changes

Review of attachment 8890350 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6db4b0af686c
part 2 - Invalidate and notify when clearing cached media features for Windows accent color changes. r=dholbert

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6db4b0af686c

Comment 17

[ovidiu boca[:Ovidiu]]

I tested this on Windows 10 with FF Nightly 57.0a1(2017-08-16) and I still can reproduce this issue.

Comment 18

[Jonathan Watt [:jwatt]]

As best I can tell we have some sort of race when there are multiple top level windows. Sometimes it works, sometimes it doesn't. Annoyingly it usually works when Firefox is run from a debugger with breakpoints set.

Ovidiu, did you notice any particular pattern of interaction that would cause it to work or not work?

Comment 19

[ovidiu boca[:Ovidiu]]

Hi Jonathan,

We retested this and we found out that on private windows this issue is always reproducible, maybe this can help you. Also, we have a screen recorder with this issue, please go to this link: https://streamable.com/xrjfr

Comment 20

[Brindusa Tot, DTE]

Verified this on latest Nightly 57.0a1, Build ID 20170914220209 with normal and private window and title bar gets the accent color.

Comment 21

[Johann Hofmann [:johannh]]

Ovidiu, considering Brindusa has this fixed on her machine, can you confirm that it's not reproducible for you anymore?

Comment 22

[ovidiu boca[:Ovidiu]]

Hi Johann, I can't reproduce this anymore, if we encounter this issue in the future we will reopen it. Thanks