Closed
Bug 1379288
Opened 7 years ago
Closed 7 years ago
Mechanism to fallback to locale specific fonts
Categories
(developer.mozilla.org Graveyard :: Localization, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: shobson, Unassigned)
References
Details
(Keywords: in-triage, Whiteboard: [specification][type:feature])
Attachments
(1 file)
45.62 KB,
image/png
|
Details |
What problem would this feature solve? ====================================== It is difficult for any single font to support the plurality of characters humans use for communication. This mechanism would allow us to specify a fallback display font optimized for individual languages. Who has this problem? ===================== All visitors to MDN How do you know that the users identified above have this problem? ================================================================== So many zilla bugs on the redesign. How are the users identified above solving this problem now? ============================================================ Open Sans had much wider character support than Zilla however we did have some complaints about the current fonts as well. Do you have any suggestions for solving the problem? Please explain in detail. ============================================================================== mozilla.org uses a system like this: - font declarations in the main style sheet include a locale specific font name (`X-LocaleSpecific`) - individual locale specific files .css files are created which provide a localized definition for `X-LocaleSpecific` - when a page in a locale is requested bedrock checks to see if there is a locale specific .css file for that local - if it is, it is included on the page *after* the main css file Is there anything else we should know? ====================================== I would like the local specific files to live in kuma/static/styles/locales/{locale}.scss Pipeline and gulp will have to be modified to handle files in subfolders.
Reporter | ||
Updated•7 years ago
|
Comment 1•7 years ago
|
||
May i can help. I can add the necessary Vietnamese characters to this font. What I have to do? I don't know how i can submit my contribute for this font. Can you help me?
Comment 2•7 years ago
|
||
Pierre, you've helped by pointing out a locale that has this issue. I don't believe we have a way to collaborate on the character set supported by the *Zilla fonts.
Reporter | ||
Comment 3•7 years ago
|
||
Hi Pierre, We don't have any control over the font unfortunately. Our solution will be to pick a different font to display to Vietnamese users. It would be helpful for us to know which default fonts have good support for Vietnamese. Do Arial and Times New Roman both have good support? Does Open Sans have good Vietnamese support? (Open Sans is the font MDN uses for headings in the old design). Thanks!
Comment 4•7 years ago
|
||
(In reply to John Whitlock [:jwhitlock] from comment #2) > Pierre, you've helped by pointing out a locale that has this issue. I don't > believe we have a way to collaborate on the character set supported by the > *Zilla fonts. This sounds sad. (In reply to Stephanie Hobson [:shobson] from comment #3) > Hi Pierre, > > We don't have any control over the font unfortunately. Our solution will be > to pick a different font to display to Vietnamese users. It would be helpful > for us to know which default fonts have good support for Vietnamese. Do > Arial and Times New Roman both have good support? Does Open Sans have good > Vietnamese support? (Open Sans is the font MDN uses for headings in the old > design). > > Thanks! Open Sans is a good font for Vietnamese. I think we should choose it.
Comment 5•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/5bd2e5f952aac5400c5a364049f5199da6c1979c bug 1379288: Include optional locale-specific CSS Include a locale-specific CSS file if it has been defined in the pipeline. Empty example for zh-CN is included, as well as helper methods for making it easier to declare these in the settings file. https://github.com/mozilla/kuma/commit/d745c9bacbe2184d12749b6d409620dfba7fabe7 bug 1379288: Build locale scss with gulp https://github.com/mozilla/kuma/commit/9ef0a954accbe86fe2921de142c750f690835a29 Merge pull request #4303 from jwhitlock/locale-specific-css bug 1379288: Include optional locale-specific CSS
Comment 6•7 years ago
|
||
On the Editor for an English page, the font doesn't seem to always be loaded properly as you can see in the attached screenshot.
Comment 7•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/00b4b1e61195b0d0372eb50e9c8835d759b4dc74 bug 1379288: General locale styles Switch to adding locale styles in a loop, from the list of locales in: - LOCALE_USE_CUSTOM - Locales with specific fonts and styles, defined in an .scss file named after the locale. - LOCALE_USE_ZILLA - Locales that are well supported by Zilla, and should use the same font and styles as en-US.scss Locales that are not in these lists will continue to use browser-defined fonts and styles. https://github.com/mozilla/kuma/commit/efd1f27b1ef709b10d2f5cc6d076df8b15967bfa bug 1379288: Add locale style to CKEditor content https://github.com/mozilla/kuma/commit/418ea22282299d56d2b00ea3d8d11a88085541f3 Merge pull request #4328 from jwhitlock/ckeditor-locale-font-1379288 bug 1379288: Use locale-specific font in CKEditor content
Comment 8•7 years ago
|
||
This code is pushed to staging and production.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•