Closed Bug 1379308 Opened 8 years ago Closed 8 years ago

Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp

Categories

(Core :: Layout, enhancement)

Product:
Core
Component:
Layout
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 obsolete file)

After encountering bug 1379282 I was looking for other examples of simplistic hash functions in the code base and there are two in this file.
Comment on attachment 8884456 [details] [diff] [review] Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp Sorry didn't mean to attach the patch. This hasn't been tested.
Attachment #8884456 - Attachment is obsolete: true
Attachment #8884456 - Flags: review?(mats)
Assignee: nobody → ehsan
It looks like the right fix though, so r=mats if you want it :-)
Heh, thanks! :-) The patch is on try. I'll land it if it turns out green!
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/575bde4cd0ac Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp; r=mats
https://hg.mozilla.org/mozilla-central/rev/575bde4cd0ac
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: