Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 obsolete attachment)

(Assignee)

Description

a year ago
After encountering bug 1379282 I was looking for other examples of simplistic hash functions in the code base and there are two in this file.
(Assignee)

Comment 1

a year ago
Created attachment 8884456 [details] [diff] [review]
Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp
Attachment #8884456 - Flags: review?(mats)
(Assignee)

Comment 2

a year ago
Comment on attachment 8884456 [details] [diff] [review]
Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp

Sorry didn't mean to attach the patch.  This hasn't been tested.
Attachment #8884456 - Attachment is obsolete: true
Attachment #8884456 - Flags: review?(mats)
(Assignee)

Updated

a year ago
Assignee: nobody → ehsan
It looks like the right fix though, so r=mats if you want it :-)
(Assignee)

Comment 4

a year ago
Heh, thanks! :-)  The patch is on try.  I'll land it if it turns out green!

Comment 5

a year ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/575bde4cd0ac
Improve the hash key generation for two of the hashtables in nsCSSRuleProcessor.cpp; r=mats

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/575bde4cd0ac
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.