Closed Bug 1379312 Opened 3 years ago Closed 2 years ago

nsRuleNetwork.h hashes 2 pointers in a custom fashion

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file, 1 obsolete file)

It's unclear whether this is a good idea, and the effectiveness of the hashing here is pretty close to what caused bug 1379282.  It's better to use HashGeneric on each one and combine the two values using XOR.
I decided to keep the weird style of this code for consistency.
Attachment #8884462 - Flags: review?(michael)
Comment on attachment 8884463 [details] [diff] [review]
Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric()

(Not sure why a second patch was submitted, sorry!)
Attachment #8884463 - Attachment is obsolete: true
Attachment #8884463 - Flags: review?(michael)
Attachment #8884462 - Flags: review?(michael) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/190aa46c11c4
Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric(); r=mystor
https://hg.mozilla.org/mozilla-central/rev/190aa46c11c4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → ehsan
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.