Closed Bug 1379312 Opened 3 years ago Closed 2 years ago
Rule Network .h hashes 2 pointers in a custom fashion
It's unclear whether this is a good idea, and the effectiveness of the hashing here is pretty close to what caused bug 1379282. It's better to use HashGeneric on each one and combine the two values using XOR.
I decided to keep the weird style of this code for consistency.
Attachment #8884462 - Flags: review?(michael)
Comment on attachment 8884463 [details] [diff] [review] Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric() (Not sure why a second patch was submitted, sorry!)
Attachment #8884462 - Flags: review?(michael) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/190aa46c11c4 Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric(); r=mystor
You need to log in before you can comment on or make changes to this bug.