1379312 - nsRuleNetwork.h hashes 2 pointers in a custom fashion

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[(no longer active)]

It's unclear whether this is a good idea, and the effectiveness of the hashing here is pretty close to what caused bug 1379282.  It's better to use HashGeneric on each one and combine the two values using XOR.

Comment 1

[(no longer active)]

Attachment: Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric()

I decided to keep the weird style of this code for consistency.

Comment 2

[(no longer active)]

Attachment: Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric()

Comment 3

[(no longer active)]

Comment on attachment 8884463 [details] [diff] [review]
Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric()

(Not sure why a second patch was submitted, sorry!)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/190aa46c11c4
Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric(); r=mystor

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/190aa46c11c4