Closed
Bug 1379312
Opened 7 years ago
Closed 7 years ago
nsRuleNetwork.h hashes 2 pointers in a custom fashion
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file, 1 obsolete file)
It's unclear whether this is a good idea, and the effectiveness of the hashing here is pretty close to what caused bug 1379282. It's better to use HashGeneric on each one and combine the two values using XOR.
|
Assignee | |
Comment 1•7 years ago
|
||
I decided to keep the weird style of this code for consistency.
Attachment #8884462 -
Flags: review?(michael)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8884463 -
Flags: review?(michael)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 8884463 [details] [diff] [review] Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric() (Not sure why a second patch was submitted, sorry!)
Attachment #8884463 -
Attachment is obsolete: true
Attachment #8884463 -
Flags: review?(michael)
|
||
Updated•7 years ago
|
Attachment #8884462 -
Flags: review?(michael) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/190aa46c11c4 Improve nsAssignment's hashing algorithm by redoing it on top of mozilla::HashGeneric(); r=mystor
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/190aa46c11c4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Updated•6 years ago
|
Assignee: nobody → ehsan
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•