Closed
Bug 1379316
Opened 7 years ago
Closed 7 years ago
Intermittent toolkit/components/telemetry/tests/unit/test_TelemetrySession.js | test_schedulerEnvironmentReschedules - [test_schedulerEnvironmentReschedules : 1890] No ping should be sent/received in this test. - false == true
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: intermittent-bug-filer, Assigned: Dexter)
References
Details
(Keywords: intermittent-failure, Whiteboard: [measurement:client][stockwell unknown])
Attachments
(1 file)
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=112596312&repo=autoland https://queue.taskcluster.net/v1/task/fuwa0M1WR6eTn5jMQlewrg/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 3•7 years ago
|
||
Looks like this was fixed by bug 1374828 as well? Bumping this to P1 to keep a close eye on it. I will close this if no new failures happen.
Points: --- → 1
Priority: -- → P1
Assignee | ||
Updated•7 years ago
|
Whiteboard: [measurement:client]
Assignee | ||
Comment 4•7 years ago
|
||
Looks like bug 1374828 reduced the volume of this, but didn't solve it. Moving it back to P2 for future investigations.
Priority: P1 → P2
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 8•7 years ago
|
||
:gfritzsche, this is failing on linux64 debug. I see you are the triage owner for telemetry, can you help find someone to look into fixing this in the next week given the high frequency of failures?
Flags: needinfo?(gfritzsche)
Whiteboard: [measurement:client] → [measurement:client][stockwell needswork]
Comment 9•7 years ago
|
||
We're on a workweek next week, but we'll try to see whats going within the next two weeks.
Flags: needinfo?(gfritzsche)
Priority: P2 → P1
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [measurement:client][stockwell needswork] → [measurement:client][stockwell unknown]
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → alessio.placitelli
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 14•7 years ago
|
||
This seems to have settled to a much lower volume. Does this still require immediate action?
Flags: needinfo?(jmaher)
Comment 15•7 years ago
|
||
yes, this is something that will be hard to reproduce.
Flags: needinfo?(jmaher)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 17•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #15) > yes, this is something that will be hard to reproduce. Heh, that's something that is *already* hard to reproduce [1]. The attached patch is a potential fix, but should be the right one because of the past experiences with bug 1374828. I've also added a more useful log message, just in case the problem happens again after this patch. [1] - https://treeherder.mozilla.org/#/jobs?repo=try&revision=40b9d96af5f4255167fceccf0d2b0bbff5463297&selectedJob=125520810
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8900798 [details] Bug 1379316 - Move test with broken telemetry init out of test_TelemetrySession.js. https://reviewboard.mozilla.org/r/172240/#review177534 ::: toolkit/components/telemetry/tests/unit/test_TelemetrySession_abortedSessionQueued.js:83 (Diff revision 1) > + > + await TelemetryController.testShutdown(); > +}); > + > +add_task(async function stopServer() { > + await PingServer.stop(); Should we wipe the datareporting path again on shutdown to be a good test citizen?
Attachment #8900798 -
Flags: review?(chutten)
Assignee | ||
Comment 19•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8900798 [details] Bug 1379316 - Move test with broken telemetry init out of test_TelemetrySession.js. https://reviewboard.mozilla.org/r/172240/#review177534 > Should we wipe the datareporting path again on shutdown to be a good test citizen? Xpcshell tests are smart enough to auto-clean after themselves: for every different test a new profile directory is created and, once the test is completed, the directory is deleted; the datareporting dir is in the user profile, so it gets deleted as well. See [here](https://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/testing/xpcshell/runxpcshelltests.py#619,748,782). I'll gladly wipe out the dir if you feel strongly about it though!
Comment 20•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8900798 [details] Bug 1379316 - Move test with broken telemetry init out of test_TelemetrySession.js. https://reviewboard.mozilla.org/r/172240/#review177534 > Xpcshell tests are smart enough to auto-clean after themselves: for every different test a new profile directory is created and, once the test is completed, the directory is deleted; the datareporting dir is in the user profile, so it gets deleted as well. See [here](https://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/testing/xpcshell/runxpcshelltests.py#619,748,782). I'll gladly wipe out the dir if you feel strongly about it though! Nah, that's fine. I just saw you wiping it at the top and thought we could be kind.
Comment 21•7 years ago
|
||
mozreview-review |
Comment on attachment 8900798 [details] Bug 1379316 - Move test with broken telemetry init out of test_TelemetrySession.js. https://reviewboard.mozilla.org/r/172240/#review177568
Attachment #8900798 -
Flags: review+
Comment hidden (mozreview-request) |
Comment 23•7 years ago
|
||
Pushed by alessio.placitelli@gmail.com: https://hg.mozilla.org/integration/autoland/rev/45c8cf39c820 Move test with broken telemetry init out of test_TelemetrySession.js. r=chutten
Comment 24•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/45c8cf39c820
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 25•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/ad0fc3b76a90
status-firefox56:
--- → fixed
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•