1379354 - Improve the UnicodeToEntity hashtable hash routine

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Comment 1

[(no longer active)]

Bug 1379282 is the motivation behind fixing this.

Comment 2

[(no longer active)]

Attachment: Improve the UnicodeToEntity hashtable hash routine

Comment 3

[Henri Sivonen (:hsivonen)]

This hash table is only used by Save As...: Web page (complete), which could do without this, and potentially by XPCOM extensions. I think we should remove the entire hash table in 57 if not already in 56.

Comment 4

[William Chen [:wchen]]

If I follow the usage of the table through the callers, I eventually get to nsDocumentEncoder::EncodeToString and that has many consumers so it seems to me that it's not just "Save As...". As for replacing the hash table, do we already have another mechanism to lookup the entity from unicode?

Comment 5

[William Chen [:wchen]]

Comment on attachment 8884501 [details] [diff] [review]
Improve the UnicodeToEntity hashtable hash routine

Review of attachment 8884501 [details] [diff] [review]:
-----------------------------------------------------------------

If this is actually a performance issue, we can probably do even better since the data in the table is static.

Comment 6

[(no longer active)]

I don't have any evidence that it is a performance issue.  I found this while auditing the code for the hash table hash functions in our code base.  In general I file these bugs so that people can wontfix them if they think they aren't worth fixing.

Comment 7

[(no longer active)]

I guess I will land the patch since it doesn't hurt anything?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20c8a416aefb
Improve the UnicodeToEntity hashtable hash routine; r=wchen

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/20c8a416aefb