1379389 - YouTube desktop-mode fullscreen controls aren't fully drawn, on Firefox for Android

Status: RESOLVED INVALID

(Core :: Web Painting, defect, P3)

Description

[Ken Riley]

Attachment: Bug.txt

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170707100209

Steps to reproduce:

In desktop mode, play any youtube video, then switch to youtube fullscreen.
Do another action, such as pause.



Actual results:

Youtube controls on the right are only partially drawn, or disappear altogether (tapping where the controls should be works as expected).


Expected results:

Youtube controls should have been properly drawn.

Comment 1

[Ken Riley]

Comment on attachment 8884529 [details]
Bug.txt

>This bug is also found in Beta 55. A similar bug (or the same) started with stable 50 and persists in stable 54.
>The difference there is that with all youtube modes (regular, theater and fullscreen) only a sliver of the controls on the right are displayed.

I'm using a Verizon Ellipsis 10 tablet running Android 5.1.

Comment 2

[Blake Wu [:bwu][:blakewu]]

That should be Youtube UI which we cannot change it. 
Can you help check if Chrome has the same problem or not?

Comment 3

[Ken Riley]

(In reply to Blake Wu [:bwu][:blakewu] from comment #2)
> That should be Youtube UI which we cannot change it. 
> Can you help check if Chrome has the same problem or not?

Chrome 59, Opera 37, and Naked Browser Pro (which renders with Webview) all work fine. That's why I think it's a Firefox bug.

Comment 4

[Blake Wu [:bwu][:blakewu]]

I cannot see this problem on my Pixel. 
Ray, 
Do you have any ideas what happens to this media control?

Comment 5

[Ken Riley]

(In reply to Blake Wu [:bwu][:blakewu] from comment #4)
> I cannot see this problem on my Pixel. 
> Ray, 
> Do you have any ideas what happens to this media control?

Just to be clear, this only happens in desktop mode.

Comment 6

[Ray Lin[:ralin]]

Hi Ken,

My phone is HTC10 with Android 7.0 + 20170716 build, and I don't spot the problem either. When I was trying to reproduce the issue, I found the media controls switch to Youtube's default controls if I requested for desktop mode. Could you provide us some screenshots? It would be easier for us to know if we see the same case? Thanks.

Comment 7

[Ken Riley]

Attachment: firefox 54 regular view

There's also the letter i within a circle at the top right of the screen that's not drawn properly.

Comment 8

[Ken Riley]

Attachment: firefox 54 theater view

Full screen control missing from bottom right; letter i in circle missing from top right.

Comment 9

[Ken Riley]

Attachment: firefox 54 full screen view

Letter i in circle missing from upper right; full screen control missing from lower right. Full screen control only disappears after some action(s) on left side such as play/pause.

Comment 10

[Ray Lin[:ralin]]

Thank you Ken for these screenshots. Looking at the screenshot, I think the issue is something rather than our built-in media controls. 


Hi, Daniel

I'm not sure who is the right person to this issue, it could be "layout" or "paint"? I guess. Do you have any idea? Thanks.

Comment 11

[Ken Riley]

Attachment: firefox 55 full screen view before action(s)

No letter i in circle and missing controls on bottom right. This is before any action(s).

Comment 12

[Ken Riley]

Attachment: firefox 55 full screen view after action(s)

Letter i in circle missing; more controls missing after action(s) such as play/pause.

Comment 13

[Ken Riley]

Attachment: firefox 56 full screen view before action(s)

Letter i in circle missing from upper right; controls missing from lower right before any action(s) such as play/pause.

Comment 14

[Ken Riley]

Attachment: firefox 56 full screen view after action(s)

Letter i in circle missing from upper right; controls missing from lower right.

As I think I mentioned before stable firefox 49 was the last version that didn't have this bug.

Comment 15

[Daniel Holbert [:dholbert]]

(In reply to Ray Lin[:ralin] from comment #10)
> Thank you Ken for these screenshots. Looking at the screenshot, I think the
> issue is something rather than our built-in media controls. 

(Agreed)

> I'm not sure who is the right person to this issue, it could be "layout" or
> "paint"? I guess. Do you have any idea? Thanks.

It's hard to know right now; could be one of those, or could be a bug in old versions of an Android graphics library that we happen to use.

I can't reproduce (on my Nexus 7 tablet running Android 7.1.2, with Firefox Nightly, with "request Desktop version" checkbox ticked).  Adding "qawanted" to see if anyone from QA has a tablet that they can reproduce this on...

(In reply to Ken Riley from comment #14)
> As I think I mentioned before stable firefox 49 was the last version that
> didn't have this bug.

Thanks, that's useful to know.  The best way to move forward here at this point would be to identify a shorter Nightly regression range, so that we can figure out some candidates for what might've caused this.  Until someone else is able to reproduce, then I think Ken is in the best position to get a tighter regression range.  Ken, would you be interested?  It might take 30-60min depending on download speeds & how much configuration needs to be done -- basically, you'd need to run the "mozregression"[1] tool on a desktop machine, with your tablet connected over USB, and it'll download & install a series of Nightly builds (6 or 7 maybe) on your tablet and then ask you if each one is good/bad, and then it'll bisect the remaining range with a build in the middle & repeat.  You'd start it off with a command like "mozregression -n fennec --good 49 --bad 50", if you're sure 49 was good and 50 is bad. (or e.g. --good 48 --bad 51 to be on the safe side, if you're less sure)

Someone in https://mibbit.com/?server=irc.mozilla.org&channel=%23mobile could help you get that going if you're interested & need help.  A few initial notes: you'll need to have developer mode + ADB debugging enabled on your tablet and adb installed on your desktop (the android debugging tool) and I believe the mozregression-installed Nightlies will stomp on your Nightly profile data on your tablet [due to uninstalling/reinstalling different versions], so you'd lose any bookmarks/addons/etc there, which is kind of a drag (though as I recall, there might also be a way to back those up if that's a deal-breaker -- or you can always restore bookmarks/history using Firefox Sync).

[1] https://mozilla.github.io/mozregression/

Comment 16

[Ken Riley]

I don't think I can help the way you suggested as I don't have access to a "real" computer, only a Verizon Ellipsis 10 tablet. Anything I can do within that framework, I'd be happy to.

Comment 17

[Daniel Holbert [:dholbert]]

[Tentatively reclassifying as "Core | Layout: Web Painting", which might not be quite right but is probably closer to the correct component.]

Comment 18

[Ken Riley]

Attachment: firefox 56-2015502929 after exiting you tube full screen

Comment 19

[Ken Riley]

With the version 56-2015502929 of nightly, controls are drawn improperly after exiting youtube fullscreen, and there is no theater button (see screenshot).

Comment 20

[Ken Riley]

Attachment: Nightly after exiting fullscreen.

Comment 21

[Ken Riley]

With last few nightly releases, after exiting youtube full screen, partly drawn full screen controls remain but are not useable (see screenshot). Only way to correct is to close tab or firefox.

Comment 22

[Ken Riley]

At long last, I've found the cause of this bug, and it's not Firefox. I was using Video Background Play Fix 1.2, which causes the bug today (and that was probably the cause originally). The latest version (1.5) of the extension fixes the bug. I thought I had ruled out extensions as the cause, but obviously hadn't.

Comment 23

[Daniel Holbert [:dholbert]]

That's great to hear! Thanks for letting us know.

Resolving as "Invalid" since this is a bug in other software, not in Firefox.