1379400 - Intermittent dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.bytesReceived is a sane number (20,000<>800,000) for a short test. value=801806

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer.html#?job_id=112766068&repo=mozilla-inbound

10:32:55     INFO -  118 INFO candidate-pair is: {"id":"xO1I","timestamp":1499509975108.575,"type":"candidate-pair","bytesReceived":801806,"bytesSent":789611,"lastPacketReceivedTimestamp":1383649338,"lastPacketSentTimestamp":1383649349,"localCandidateId":"P4bi","nominated":true,"priority":9115005270282338000,"readable":true,"remoteCandidateId":"OWxu","selected":true,"state":"succeeded","transportId":"0-1499509962677000 (id=4294967356 url=http://mochi.test:8888/tests/dom/media/tests/mochitest/test_peerConnection_stats.html) aLevel=0","writable":true}
10:32:55     INFO -  119 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.transportId has a value. value=0-1499509962677000 (id=4294967356 url=http://mochi.test:8888/tests/dom/media/tests/mochitest/test_peerConnection_stats.html) aLevel=0
10:32:55     INFO -  120 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.localCandidateId has a value. value=P4bi
10:32:55     INFO -  121 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.remoteCandidateId has a value. value=OWxu
10:32:55     INFO -  122 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.priority has a value. value=9115005270282338000
10:32:55     INFO -  123 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.readable is true. value=true
10:32:55     INFO -  124 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.writable is true. value=true
10:32:55     INFO -  125 INFO candidate-pair state is succeeded and selected is true
10:32:55     INFO -  126 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.nominated is true. value=true
10:32:55     INFO -  127 INFO TEST-PASS | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.bytesSent is a sane number (20,000<>800,000)for a short test. value=789611
10:32:55     INFO -  Buffered messages finished
10:32:55    ERROR -  128 INFO TEST-UNEXPECTED-FAIL | dom/media/tests/mochitest/test_peerConnection_stats.html | candidate-pair.bytesReceived is a sane number (20,000<>800,000) for a short test. value=801806
10:32:55     INFO -      pedanticChecks/<@dom/media/tests/mochitest/test_peerConnection_stats.html:433:9
10:32:55     INFO -      pedanticChecks@dom/media/tests/mochitest/test_peerConnection_stats.html:111:3
10:32:55     INFO -      PC_REMOTE_TEST_REMOTE_STATS/<@dom/media/tests/mochitest/test_peerConnection_stats.html:534:5
10:32:55     INFO -      promise callback*PC_REMOTE_TEST_REMOTE_STATS@dom/media/tests/mochitest/test_peerConnection_stats.html:532:10
10:32:55     INFO -      execute/</<@dom/media/tests/mochitest/head.js:746:31
10:32:55     INFO -      promise callback*execute/<@dom/media/tests/mochitest/head.js:744:14
10:32:55     INFO -      execute@dom/media/tests/mochitest/head.js:739:12
10:32:55     INFO -      async*runTestWhenReady/<@dom/media/tests/mochitest/head.js:370:41
10:32:55     INFO -      promise callback*runTestWhenReady@dom/media/tests/mochitest/head.js:370:10
10:32:55     INFO -      runNetworkTest@dom/media/tests/mochitest/pc.js:2042:9
10:32:55     INFO -      async*@dom/media/tests/mochitest/test_peerConnection_stats.html:539:1

Comment 1

[Nils Ohlmeier [:drno]]

Michael looks like we need to increase the numbers here :-)

Comment 2

[Intermittent Failures Robot]

1 failures in 656 pushes (0.002 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 1

Platform breakdown:
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1379400&startday=2017-07-03&endday=2017-07-09&tree=all

Comment 3

[Michael Froman [:mjf]]

(In reply to Nils Ohlmeier [:drno] from comment #1)
> Michael looks like we need to increase the numbers here :-)

I'll remove the upper bound check - it doesn't really give us much value anyway.

Comment 4

[Michael Froman [:mjf]]

Attachment: Bug 1379400 - remove upper limit on "sane" value for bytes received or sent.

We're not really gaining much information by checking for an upper limit on
the bytesReceived or bytesSent stat here.  This should help with
intermittent failures.

Review commit: https://reviewboard.mozilla.org/r/155736/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155736/

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8884861 [details]
Bug 1379400 - remove upper limit on "sane" value for bytes received or sent.

https://reviewboard.mozilla.org/r/155736/#review160822

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

We received 783 KB?

Comment 7

[Michael Froman [:mjf]]

(In reply to Jan-Ivar Bruaroey [:jib] from comment #6)
> We received 783 KB?

That value isn't typical, but isn't unheard of from what I've seen running the test locally.  This particular test seems to run between 10 and 22 seconds here.  Maybe the variability in the test runs is a separate bug?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8983a62bf048
remove upper limit on "sane" value for bytes received or sent. r=drno

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8983a62bf048