1379421 - stylo: Remove dead code in ServoRestyleManager.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Bug 1297899 left a whole lot of dead code that has confused me a lot while debugging bug 1379203.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1379421: Remove dead code in ServoRestyleManager.

Review commit: https://reviewboard.mozilla.org/r/155470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155470/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1379421: Remove unneeded null-checks in RestyleManager.

Container is the result of dereferencing a non-null variable, so there's no way
that can be null.

Review commit: https://reviewboard.mozilla.org/r/155468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155468/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8884581 [details]
Bug 1379421: Remove dead code in ServoRestyleManager.

https://reviewboard.mozilla.org/r/155470/#review160498

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8884582 [details]
Bug 1379421: Remove unneeded null-checks in RestyleManager.

https://reviewboard.mozilla.org/r/155468/#review160500

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e38da505d63f
Remove dead code in ServoRestyleManager. r=heycam
https://hg.mozilla.org/integration/autoland/rev/a3bc7a02a48e
Remove unneeded null-checks in RestyleManager. r=heycam

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe590db882de
followup: Remove more dead code, and mark RestyleManager::mType as protected. r=me

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e38da505d63f
https://hg.mozilla.org/mozilla-central/rev/a3bc7a02a48e
https://hg.mozilla.org/mozilla-central/rev/fe590db882de