Closed
Bug 1379474
Opened 8 years ago
Closed 8 years ago
Update various ReflowInput variable names to match the new type name
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file, 1 obsolete file)
|
39.97 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
We have a bunch of ReflowInput variable names that are still named with "state" or "size" or similar and were never updated when the argument type was changed to ReflowInput. This patch cleans that up.
| Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8884641 -
Flags: review?(mats)
| Assignee | ||
Comment 2•8 years ago
|
||
Looks like Mats is away until August, so redirecting to Xidorn.
Attachment #8884641 -
Attachment is obsolete: true
Attachment #8884641 -
Flags: review?(mats)
Attachment #8884642 -
Flags: review?(xidorn+moz)
Comment 3•8 years ago
|
||
Comment on attachment 8884642 [details] [diff] [review]
patch
Review of attachment 8884642 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/generic/ReflowInput.cpp
@@ +781,1 @@
>
As far as you are here, could you also strip the tailing spaces on line 777 and 781, and wrap the "break;" into brace according to the coding style?
Attachment #8884642 -
Flags: review?(xidorn+moz) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31c43a9ffa8b
Update various ReflowInput variable names to match the new type name. r=xidorn
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0e7d5dcc8ad
Backed out changeset 31c43a9ffa8b for bustage
Updated•8 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd1e362339c5
Update various ReflowInput variable names to match the new type name. r=xidorn
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•