Closed Bug 1379478 Opened 7 years ago Closed 5 years ago

Audit all uses of Bundle.object(forInfoDictionaryKey)

Categories

(Firefox for iOS :: General, enhancement)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: st3fan, Unassigned)

Details

(Whiteboard: [MobileCore]) 

We call Bundle.object(forInfoDictionaryKey) from a number of places to lookup things like the application version number, build number, and other values. All these cases should really be refactored to use AppInfo if possible. Where it makes sense.
Used only in LeanplumIntegration.swift and AdjustIntegration.swift. 
Not sure if getting the main app bundle is intentional there (as AppInfo has the feature of grabbing the plugin bundle when run from that context).

https://github.com/mozilla-mobile/firefox-ios/blob/1e0a6cd2b949b3b97ac2f1ca806211ecdbebfc01/Client/Application/LeanplumIntegration.swift#L177

https://github.com/mozilla-mobile/firefox-ios/blob/dae882fbadd4e467f7a6e4f04007528931fffddc/Client/Application/AdjustIntegration.swift#L62
Removing papercut flag, I don't think this needs that level of attention
Whiteboard: [MobileCore][papercut] → [MobileCore]
Stefan please confirm I can de-papercut this one
Flags: needinfo?(sarentz)
Flags: needinfo?(sarentz)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.