Audit all uses of Bundle.object(forInfoDictionaryKey)

NEW
Unassigned

Status

()

Firefox for iOS
General
11 months ago
4 months ago

People

(Reporter: st3fan, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MobileCore])

(Reporter)

Description

11 months ago
We call Bundle.object(forInfoDictionaryKey) from a number of places to lookup things like the application version number, build number, and other values. All these cases should really be refactored to use AppInfo if possible. Where it makes sense.

Comment 1

10 months ago
Used only in LeanplumIntegration.swift and AdjustIntegration.swift. 
Not sure if getting the main app bundle is intentional there (as AppInfo has the feature of grabbing the plugin bundle when run from that context).

https://github.com/mozilla-mobile/firefox-ios/blob/1e0a6cd2b949b3b97ac2f1ca806211ecdbebfc01/Client/Application/LeanplumIntegration.swift#L177

https://github.com/mozilla-mobile/firefox-ios/blob/dae882fbadd4e467f7a6e4f04007528931fffddc/Client/Application/AdjustIntegration.swift#L62

Comment 2

10 months ago
Removing papercut flag, I don't think this needs that level of attention
Whiteboard: [MobileCore][papercut] → [MobileCore]

Comment 3

10 months ago
Stefan please confirm I can de-papercut this one
Flags: needinfo?(sarentz)
(Reporter)

Updated

4 months ago
Flags: needinfo?(sarentz)
You need to log in before you can comment on or make changes to this bug.