1379538 - Unresolved symbols when linking program to standalone SpiderMonkey

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Philip Chimento [:ptomato]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36

Steps to reproduce:

There are a few symbols that need to be marked as exported in the SpiderMonkey shared library, because they are used in the public headers.


Actual results:

Building a program that includes the SpiderMonkey public headers, fails with js::oom::GetThreadType() and js::ReportOutOfMemory() unresolvable.

Comment 1

[Philip Chimento [:ptomato]]

Attachment: headers: Fix symbols visibility

Here's a patch that works for me.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8884717 [details] [diff] [review]
headers: Fix symbols visibility

Review of attachment 8884717 [details] [diff] [review]:
-----------------------------------------------------------------

Nick, this looks ok to me. WDYT?

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8884717 [details] [diff] [review]
headers: Fix symbols visibility

Review of attachment 8884717 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Do you have commit access to push to try? If not, I can take this the rest of the way for you.

Comment 4

[Philip Chimento [:ptomato]]

Cool, thanks for the reviews. I don't have commit access, so I'd appreciate if you could do the push.

Would it be possible to request backporting to ESR52, in preparation for an official tarball release, since this is pretty much required in order to use the tarball? Can I do that myself just by setting the "approval-mozilla-esr52?" flag?

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2114b7b56d8b

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Unresolved symbols when linking program to standalone SpiderMonkey

Some symbols that need to be public are not marked as such.

(This is the same patch, but with an m-c formatted message.)

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8885381 [details] [diff] [review]
Unresolved symbols when linking program to standalone SpiderMonkey

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: required for people embedding standalone spidermonkey 52
User impact if declined: people won't be able to embed standalone spidermonkey 52
Fix Landed on Version: in the process of landing now
Risk to taking this patch (and alternatives if risky): none
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 8

[Philip Chimento [:ptomato]]

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64c2fbd4b88c
Unresolved symbols when linking program to standalone SpiderMonkey. r=fitzgen

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64c2fbd4b88c

Comment 11

[Gerry Chang [:gchang]]

Comment on attachment 8885381 [details] [diff] [review]
Unresolved symbols when linking program to standalone SpiderMonkey

This is needed for SpiderMonkey and low risk. Let's uplift it to ESR52.3.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/8fa66bc91b078252135c4c603d0abcb9e049bc8c