1379689 - JSON with EDITOR_CONFIG key not visible in netmonitor

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Oriol Brufau [:Oriol]]

Attachment: testcase.json

Open netmonitor and load attached testcase.
Go to the Response tab.
Problems:

 - EDITOR_CONFIG subtree is not visible
 - The other JSON is aligned to the bottom
 - The filter textbox is hidden

This is caused by https://dxr.mozilla.org/mozilla-central/rev/6e542037f6d4013f9e0cffd4e8d801790bbe091d/devtools/client/netmonitor/src/components/properties-view.js#100-103

    // Skip for editor config
    if (level >= 1 && path.includes(EDITOR_CONFIG_ID)) {
      return null;
    }

TreeView should expose the path components, and then netmonitor should just check pathComponents[1] === EDITOR_CONFIG_ID.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can reproduce the problem using STRs from comment #0

Thanks for the report Oriol!

Honza

Comment 2

[Oriol Brufau [:Oriol]]

Solving this won't be as simple as I thought. The problem is not only that path.includes(EDITOR_CONFIG_ID) searches in the whole path. The editor is loaded by a JSON_CONFIG key at level 1, and the data is at level 2; but the JSON data starts at level 1. And the names of the level 0 keys that contain the JSON or the editor are not known beforehand, because they are L10N strings.

Comment 3

[Oriol Brufau [:Oriol]]

Fixed in https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=eaac96bf8116f7e0d7c485c79b51153abc3df986&tochange=8ef0a54d7715018ad09e5b6b53d3321252422e44
Probably bug 1613885