Closed
Bug 1379704
Opened 8 years ago
Closed 7 years ago
Update update-jsoncpp.sh to match new location of jsoncpp
Categories
(Core :: WebVR, enhancement, P2)
Core
WebVR
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: kip, Assigned: kip)
References
Details
Attachments
(1 file)
In bug 1356382, jsoncpp was moved from toolkit/crashreporter to toolkit/components.
As per Bug 1356382 Comment 14, the update-jsoncpp.sh script should be be updated to reflect the new location.
Assignee | ||
Comment 1•8 years ago
|
||
In addition to updating the script, it should be moved from toolkit/crashreporter to toolkit/components
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → kgilbert
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8884985 -
Flags: review?(choller)
Updated•8 years ago
|
Attachment #8884985 -
Flags: review?(choller)
Comment 3•8 years ago
|
||
I canceled review here because I can't review this. I suggest pinging one of the build/crashreporter/toolkit peers, maybe :ted or :froydnj. But both are on PTO right now, so you might have to wait.
Assignee | ||
Comment 4•7 years ago
|
||
This will need to land in FF58+
status-firefox57:
--- → wontfix
Priority: -- → P2
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8884985 [details]
Bug 1379704 - Move and update update-jsoncpp.sh script to match new location of jsoncpp library
https://reviewboard.mozilla.org/r/155812/#review265468
Seems straightforward. We should add a moz.yaml file for this at some point.
Attachment #8884985 -
Flags: review+
Updated•7 years ago
|
Flags: needinfo?(ted)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4d268f4ed8a3
Move and update update-jsoncpp.sh script to match new location of jsoncpp library r=ted
Comment 8•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•