Closed Bug 1379704 Opened 5 years ago Closed 4 years ago

Update update-jsoncpp.sh to match new location of jsoncpp

Categories

(Core :: WebVR, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox57 --- wontfix
firefox63 --- fixed

People

(Reporter: kip, Assigned: kip)

References

Details

Attachments

(1 file)

In bug 1356382, jsoncpp was moved from toolkit/crashreporter to toolkit/components.

As per Bug 1356382 Comment 14, the update-jsoncpp.sh script should be be updated to reflect the new location.
In addition to updating the script, it should be moved from toolkit/crashreporter to toolkit/components
See Also: → 1356382
Assignee: nobody → kgilbert
Attachment #8884985 - Flags: review?(choller)
Attachment #8884985 - Flags: review?(choller)
I canceled review here because I can't review this. I suggest pinging one of the build/crashreporter/toolkit peers, maybe :ted or :froydnj. But both are on PTO right now, so you might have to wait.
This will need to land in FF58+
Priority: -- → P2
Ted, can you rubberstamp this?
Flags: needinfo?(ted)
Comment on attachment 8884985 [details]
Bug 1379704 - Move and update update-jsoncpp.sh script to match new location of jsoncpp library

https://reviewboard.mozilla.org/r/155812/#review265468

Seems straightforward. We should add a moz.yaml file for this at some point.
Attachment #8884985 - Flags: review+
Flags: needinfo?(ted)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4d268f4ed8a3
Move and update update-jsoncpp.sh script to match new location of jsoncpp library r=ted
https://hg.mozilla.org/mozilla-central/rev/4d268f4ed8a3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.