Update update-jsoncpp.sh to match new location of jsoncpp

RESOLVED FIXED in Firefox 63

Status

()

P2
normal
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: kip, Assigned: kip)

Tracking

unspecified
mozilla63
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
In bug 1356382, jsoncpp was moved from toolkit/crashreporter to toolkit/components.

As per Bug 1356382 Comment 14, the update-jsoncpp.sh script should be be updated to reflect the new location.
(Assignee)

Comment 1

a year ago
In addition to updating the script, it should be moved from toolkit/crashreporter to toolkit/components
(Assignee)

Updated

a year ago
See Also: → bug 1356382
(Assignee)

Updated

a year ago
Assignee: nobody → kgilbert
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8884985 - Flags: review?(choller)
Attachment #8884985 - Flags: review?(choller)
I canceled review here because I can't review this. I suggest pinging one of the build/crashreporter/toolkit peers, maybe :ted or :froydnj. But both are on PTO right now, so you might have to wait.
(Assignee)

Comment 4

a year ago
This will need to land in FF58+
status-firefox57: --- → wontfix
Priority: -- → P2
Ted, can you rubberstamp this?
Flags: needinfo?(ted)

Comment 6

4 months ago
mozreview-review
Comment on attachment 8884985 [details]
Bug 1379704 - Move and update update-jsoncpp.sh script to match new location of jsoncpp library

https://reviewboard.mozilla.org/r/155812/#review265468

Seems straightforward. We should add a moz.yaml file for this at some point.
Attachment #8884985 - Flags: review+
Flags: needinfo?(ted)

Comment 7

4 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4d268f4ed8a3
Move and update update-jsoncpp.sh script to match new location of jsoncpp library r=ted

Comment 8

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4d268f4ed8a3
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.