Closed
Bug 1379728
Opened 4 years ago
Closed 4 years ago
onclose event handler is buggy for HTML
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(2 files)
3.29 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
1.31 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This was added for HTML in bug 1322938, but the patches there added this bit to EventNameList.h: EVENT(close, eClose, EventNameType_HTML, eBasicEventClass) but left in place this bit: NON_IDL_EVENT(close, eWindowClose, EventNameType_XUL, eBasicEventClass) As a result, in nsContentUtils::InitializeEventTable we end up clobbering the former definition with the latter one, and the mType in the table ends up EventNameType_XUL, not EventNameType_HTML. This means "onclose" is not treated as an event handler attribute in HTML, which causes http://w3c-test.org/html/webappapis/scripting/events/event-handler-all-global-events.html to fail the "onclose" bits.
![]() |
Assignee | |
Comment 2•4 years ago
|
||
Attachment #8884972 -
Flags: review?(bugs)
![]() |
Assignee | |
Comment 3•4 years ago
|
||
Attachment #8884973 -
Flags: review?(bugs)
Updated•4 years ago
|
Attachment #8884973 -
Flags: review?(bugs) → review+
Updated•4 years ago
|
Attachment #8884972 -
Flags: review?(bugs) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/efa1a50149e5 part 1. Remove the double-definition of the 'close' event from EventNameList.h. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/e3bb0b805eca part 2. Add assertions to ensure we don't multiple-define events in our event name list. r=smaug
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/efa1a50149e5 https://hg.mozilla.org/mozilla-central/rev/e3bb0b805eca
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•2 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•