1379728 - onclose event handler is buggy for HTML

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky, bz on IRC]]

This was added for HTML in bug 1322938, but the patches there added this bit to EventNameList.h:


  EVENT(close,
        eClose,
        EventNameType_HTML,
        eBasicEventClass)

but left in place this bit:


  NON_IDL_EVENT(close,
                eWindowClose,
                EventNameType_XUL,
                eBasicEventClass)

As a result, in nsContentUtils::InitializeEventTable we end up clobbering the former definition with the latter one, and the mType in the table ends up EventNameType_XUL, not EventNameType_HTML.  This means "onclose" is not treated as an event handler attribute in HTML, which causes http://w3c-test.org/html/webappapis/scripting/events/event-handler-all-global-events.html to fail the "onclose" bits.

Comment 2

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Attachment: part 1. Remove the double-definition of the 'close' event from EventNameList.h

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Attachment: part 2. Add assertions to ensure we don't multiple-define events in our event name list

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efa1a50149e5
part 1.  Remove the double-definition of the 'close' event from EventNameList.h.  r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3bb0b805eca
part 2.  Add assertions to ensure we don't multiple-define events in our event name list.  r=smaug

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/efa1a50149e5
https://hg.mozilla.org/mozilla-central/rev/e3bb0b805eca