1379826 - Use static_cast instead of a C style cast in APZ keyboard logs

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

Just a small clean up, I think static_cast makes more sense.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1379826 - Use static_cast instead of a C style cast in APZ keyboard logs.

Review commit: https://reviewboard.mozilla.org/r/155838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155838/

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8885013 [details]
Bug 1379826 - Use static_cast instead of a C style cast in APZ keyboard logs.

https://reviewboard.mozilla.org/r/155838/#review161016

r+ with the compiler error fixed

::: gfx/layers/apz/src/FocusState.cpp:49
(Diff revision 1)
>                     const FocusTarget& aState)
>  {
>    FS_LOG("Update with rlt=%" PRIu64 ", olt=%" PRIu64 ", ft=(%d, %" PRIu64 ")\n",
>           aRootLayerTreeId,
>           aOriginatingLayersId,
> -         (int)aState.mType,
> +         static_cast<int>(intaState.mType),

There's a compiler error on this line (a spurious "int")

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

Ah, I compiled it, but without FS_LOG defined so it ate the error. That confused me for a bit. Good catch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/450d0250f58c
Use static_cast instead of a C style cast in APZ keyboard logs. r=botond

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/450d0250f58c