tabs.Tab.audible returns incorrect result for muted tabs that are playing sound
Categories
(WebExtensions :: General, defect, P5)
Tracking
(Not tracked)
People
(Reporter: rowbot, Unassigned)
Details
(Keywords: dev-doc-complete, Whiteboard: [tabs])
Reporter | ||
Comment 1•8 years ago
|
||
Reporter | ||
Comment 2•8 years ago
|
||
Reporter | ||
Comment 3•8 years ago
|
||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
Reporter | ||
Comment 6•8 years ago
|
||
Comment 7•8 years ago
|
||
Updated•8 years ago
|
Reporter | ||
Comment 8•8 years ago
|
||
Comment 9•8 years ago
|
||
Comment 10•8 years ago
|
||
Updated•8 years ago
|
Updated•8 years ago
|
Updated•7 years ago
|
Comment 11•7 years ago
|
||
Comment 12•6 years ago
|
||
I’m being blocked by this problem too, on Tab Center Reborn, which display an alternative vertical tab in a side panel.
One of my user like to have some pinned tabs muted, but she more often than not click on the muted indicator by mistake, and would prefer the icon being only visible when the tab could be producing sound. Obviously being it all the time is useless for her, she only wants to know if a tab is muted when it’s supposed to produce sound, and this is the only moment she needs quick access to the unmute feature.
Also, being consistent with Chrome is also important IMHO — no need to have yet another difference between WebExtensions implementations.
Anyway, if you finally decide you don’t want to change the current behavior, it would be better to make the docs unambiguous about what audible
is really used for in different browsers.
Comment 13•6 years ago
|
||
Details about audible
are updated on the tabs.Tab. As Andy is no longer around, who can I get to review?
Comment 14•6 years ago
|
||
I just tested on Firefox 70.0.1 and Chrome 78.0.3904.108 on Linux, and the "audible" property is independent of the tab muting feature. This seems to always have been Firefox's behavior, ever since the API was introduced in bug 1238311 .
I've updated the documentation accordingly: https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/Tab$compare?locale=en-US&to=1592300&from=1592015
Richard, could you check which version looks better? If you think that the original version (before your edit) looks clearer, please revert to that version: https://wiki.developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/Tab$compare?locale=en-US&to=1592015&from=1584878
Updated•6 years ago
|
Comment 15•6 years ago
|
||
Thanks Rob, I've clarified the second sentence on the basis that if the tab is muted the user will hear nothing; the original sentence suggested muting may or may not stop sound from being produced. The new sentence reads "However, the user will not hear the sound if the tab is muted (see the mutedInfo property)." Please let me know if you happy with this change.
Comment 16•6 years ago
|
||
Looks good, thanks!
Description
•