1379860 - shipping origin new tab page view by default

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[[e-mail]]

as bug 1369287 comment 22, PM decide to use the origin new tab page view

Comment 1

[[e-mail]]

Attachment: Bug 1379860 - shipping origin new tab page view by default;

Review commit: https://reviewboard.mozilla.org/r/156020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156020/

Comment 2

[[e-mail]]

Comment on attachment 8885150 [details]
Bug 1379860 - shipping origin new tab page view by default;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156020/diff/1-2/

Comment 3

[:Gijs (out for now; he/him)]

Comment on attachment 8885150 [details]
Bug 1379860 - shipping origin new tab page view by default;

https://reviewboard.mozilla.org/r/156020/#review161130

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87ea5fe012f3
shipping origin new tab page view by default;r=Gijs

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/87ea5fe012f3

Comment 6

[Marco Castelluccio [:marco]]

Is this a backout of the patch from bug 1369287? The commit message is pretty confusing if it is.

Comment 7

[[e-mail]]

Marco, it's a partial backout but keeps all the test cases

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Fred Lin [:gasolin] from comment #7)
> Marco, it's a partial backout but keeps all the test cases

I read Marco's comment on bug 1369287. My assumption was that the part that didn't get backout shouldn't be visible to users but Marco suggest otherwise. Could you clarify that and also back out everything that is user visible? Let's not wait for Marco for filing these bugs.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Specifically, bug 1369287 comment 28.

Comment 10

[[e-mail]]

The patch is pretty simple and only contains pref change.

Origin pref: 5x3
-> compact pref: 6x2 (bug 1369287)
-> Origin pref: 5x3 (this PR)

I'm sure I backout everything user visible.

Comment 11

[[e-mail]]

I found my old screencast recoding in 6/16 (after any of above changes) http://recordit.co/4sk1qfHf37

which shows 4 columns, but it just means the tile is auto-reordered due to the screen width.

Comment 12

[[e-mail]]

(I mean 'before' any of above changes)

Comment 13

[[e-mail]]

Attachment: screen compare between nightly and release

Here's the screen compare between nightly(top) and release(bottom) version, on mackbook air the tile looks the same.

Comment 14

[Marco Castelluccio [:marco]]

I've filed bug 1380583, but I can't reproduce in a clean profile, so that's good news.

Comment 15

[Justin [:JW_SoftvisionQA]]

I have confirmed this fix on todays Nightly.