as bug 1369287 comment 22, PM decide to use the origin new tab page view
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Priority: -- → P1
QA Contact: jwilliams
Target Milestone: --- → Firefox 56
Comment on attachment 8885150 [details] Bug 1379860 - shipping origin new tab page view by default; https://reviewboard.mozilla.org/r/156020/#review161130
Attachment #8885150 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/87ea5fe012f3 shipping origin new tab page view by default;r=Gijs
Is this a backout of the patch from bug 1369287? The commit message is pretty confusing if it is.
Marco, it's a partial backout but keeps all the test cases
(In reply to Fred Lin [:gasolin] from comment #7) > Marco, it's a partial backout but keeps all the test cases I read Marco's comment on bug 1369287. My assumption was that the part that didn't get backout shouldn't be visible to users but Marco suggest otherwise. Could you clarify that and also back out everything that is user visible? Let's not wait for Marco for filing these bugs.
Specifically, bug 1369287 comment 28.
The patch is pretty simple and only contains pref change. Origin pref: 5x3 -> compact pref: 6x2 (bug 1369287) -> Origin pref: 5x3 (this PR) I'm sure I backout everything user visible.
I found my old screencast recoding in 6/16 (after any of above changes) http://recordit.co/4sk1qfHf37 which shows 4 columns, but it just means the tile is auto-reordered due to the screen width.
(I mean 'before' any of above changes)
Here's the screen compare between nightly(top) and release(bottom) version, on mackbook air the tile looks the same.
I've filed bug 1380583, but I can't reproduce in a clean profile, so that's good news.
I have confirmed this fix on todays Nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.