1379872 - Initialize ProtocolProxyService early in startup

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Shian-Yow Wu [:swu]]

Follow up bug from https://bugzilla.mozilla.org/show_bug.cgi?id=1366133#c26

Comment 1

[Shian-Yow Wu [:swu]]

Gary, would you like to take a look at this?

Comment 2

[Gary Chen [:xeonchen]]

Attachment: Bug 1379872 - early initialize ProtocolProxyService;

Review commit: https://reviewboard.mozilla.org/r/162010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162010/

Comment 3

[Gary Chen [:xeonchen]]

Comment on attachment 8890805 [details]
Bug 1379872 - early initialize ProtocolProxyService;

this causes test failure, cancel review first.

Comment 4

[Gary Chen [:xeonchen]]

Comment on attachment 8890805 [details]
Bug 1379872 - early initialize ProtocolProxyService;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/162010/diff/1-2/

Comment 5

[Daniel Stenberg [:bagder]]

The r? is left on the patch itself, but given the more recent comment I'll hold off...

Comment 6

[Gary Chen [:xeonchen]]

(In reply to Daniel Stenberg [:bagder] from comment #5)
> The r? is left on the patch itself, but given the more recent comment I'll
> hold off...

I found the reason that breaks on try, and filed bug 1386168 for follow-up.

Looks like it passes on try now, so please feel free to review :)

Comment 7

[Daniel Stenberg [:bagder]]

Comment on attachment 8890805 [details]
Bug 1379872 - early initialize ProtocolProxyService;

https://reviewboard.mozilla.org/r/162010/#review177914

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4251e7033a49
early initialize ProtocolProxyService; r=bagder

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4251e7033a49