Closed
Bug 1379887
Opened 7 years ago
Closed 6 years ago
Don't clobber the value of mWillBuildScrollableLayer when we are building a display list for event handling
Categories
(Core :: Web Painting, enhancement)
Core
Web Painting
Tracking
()
RESOLVED
DUPLICATE
of bug 1408607
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
5.24 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
Matt debug this as causing a test failure with retained display lists. It might be causing other problems on central so I want to fix this on m-c.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8885112 -
Flags: review?(mstange)
Comment 2•7 years ago
|
||
Comment on attachment 8885112 [details] [diff] [review] decidebool Review of attachment 8885112 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/generic/nsGfxScrollFrame.cpp @@ +3605,5 @@ > > bool wasUsingDisplayPort = false; > bool usingDisplayPort = false; > nsIContent* content = mOuter->GetContent(); > + usingDisplayPort = wasUsingDisplayPort = nsLayoutUtils::HasDisplayPort(content); Please reorder this as follows: nsIContent* content = mOuter->GetContent(); bool wasUsingDisplayPort = nsLayoutUtils::HasDisplayPort(content); bool usingDisplayPort = wasUsingDisplayPort;
Attachment #8885112 -
Flags: review?(mstange) → review+
Pushed by tnikkel@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bc4c5281f2c2 Don't clobber the value of mWillBuildScrollableLayer when we are building a display list for event handling. r=mstange
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc4c5281f2c2
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Comment 5•7 years ago
|
||
backed this out https://hg.mozilla.org/integration/mozilla-inbound/rev/58ec9fceb4acff9dfbb798d9cf9a859af6295521
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla56 → ---
Comment 6•7 years ago
|
||
backout bugherder |
Merge of backout: https://hg.mozilla.org/mozilla-central/rev/58ec9fceb4ac
Updated•7 years ago
|
status-firefox56:
fixed → ---
Assignee | ||
Comment 7•6 years ago
|
||
I ended up making all the changes I wanted to make here in different bugs. Bug 1408607 was one of them, but there were others.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•