1379976 - New Mail Account wizard doesn't allow setup of .academy mail address

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Onno Ekker [:nONoNonO UTC+1]]

In sumo a question was asked about account setup for an .academy account:https://support.mozilla.org/en-US/questions/1167346

Looking at the source code https://dxr.mozilla.org/comm-central/source/mail/components/accountcreation/content/emailWizard.js#36 there's some fuzzy logic as to how an email address should look like, where the last part is limited to 6 characters. However, looking at https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#Brand_top-level_domains there are much longer top level domains, of up to 15 characters.

The code should be changed to allow to setup an email address for these accounts as well.

Comment 1

[Jorg K (CEST = GMT+2)]

Something for Aceman to look into.

Comment 2

[:aceman]

Yeah, the mess with allowing any top level domains...

So let's expand the regex.

Comment 3

[:aceman]

I've tried it entering .academy email into the account creation wizard. There is the "Double check this email address" warning, but it does not prevent continuing in the wizard. I did create such an account successfully.
BenB, do you think we should loosen the regex to allow any string in the top level domain, or we can live with the warning for people having one of the new long top level domains?

Comment 4

[Ben Bucksch (:BenB)]

It's this glibberish of regexp:
var emailRE = /^[-_a-z0-9\'+*$^&%=~!?{}]+(?:\.[-_a-z0-9\'+*$^&%=~!?{}]+)*@(?:[-a-z0-9.]+\.[a-z]{2,6}|\d{1,3}(?:\.\d{1,3}){3})(?::\d+)?$/i;
https://dxr.mozilla.org/comm-central/source/mail/components/accountcreation/content/emailWizard.js#36
https://dxr.mozilla.org/comm-central/source/mail/components/accountcreation/content/emailWizard.js#429

Yeah, let's fix the regexp.

Comment 6

[:aceman]

Attachment: 1379976.patch

OK, I increased it to 20 for some future-proofness ;)

Comment 7

[Ben Bucksch (:BenB)]

Comment on attachment 8933038 [details] [diff] [review]
1379976.patch

r+

Comment 8

[:aceman]

Thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8cd26835235c
allow longer top level domains in account wizard. r=BenB