Closed Bug 1379980 Opened 4 years ago Closed 4 years ago

Clean up RegExp code a bit

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
This removes some unnecessary roots and makes sure we fire the pre-barrier in initIgnoringLastIndex by using sharedRef instead of NativeObject::setPrivate(nullptr). Before bug 1378736 we didn't have that pre-barrier.
Attachment #8885261 - Flags: review?(jcoppeard)
Comment on attachment 8885261 [details] [diff] [review]
Patch

Review of attachment 8885261 [details] [diff] [review]:
-----------------------------------------------------------------

Ugh, thanks for fixing that!
Attachment #8885261 - Flags: review?(jcoppeard) → review+
Ugh, today is not my day apparently. This was green on Try but I messed up rebasing to tip.
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d63c9e7de4c5
Backed out changeset 32a13d3e2902 for bustage
Flags: needinfo?(jdemooij)
https://hg.mozilla.org/mozilla-central/rev/23814434a6bc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.