Closed
Bug 1379980
Opened 8 years ago
Closed 8 years ago
Clean up RegExp code a bit
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
Details
Attachments
(1 file)
|
10.29 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
This removes some unnecessary roots and makes sure we fire the pre-barrier in initIgnoringLastIndex by using sharedRef instead of NativeObject::setPrivate(nullptr). Before bug 1378736 we didn't have that pre-barrier.
Attachment #8885261 -
Flags: review?(jcoppeard)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8885261 [details] [diff] [review]
Patch
Review of attachment 8885261 [details] [diff] [review]:
-----------------------------------------------------------------
Ugh, thanks for fixing that!
Attachment #8885261 -
Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/32a13d3e2902
Clean up RegExp code a bit. r=jonco
|
||
Comment 3•8 years ago
|
||
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=113351106&repo=mozilla-inbound
Flags: needinfo?(jdemooij)
|
Assignee | |
Comment 4•8 years ago
|
||
Ugh, today is not my day apparently. This was green on Try but I messed up rebasing to tip.
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d63c9e7de4c5
Backed out changeset 32a13d3e2902 for bustage
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23814434a6bc
Clean up RegExp code a bit. r=jonco
|
|
Assignee | |
Updated•8 years ago
|
Flags: needinfo?(jdemooij)
|
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•