Closed Bug 1379982 Opened 2 years ago Closed 2 years ago

mach webrtc-gtest does not work on mac

Categories

(Core :: WebRTC, enhancement, P3)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: dminor, Assigned: dminor)

Details

Attachments

(1 file, 1 obsolete file)

On mac, the webrtc.org gtests binary does not end up in the place where the mach command expects to find it.
Attached patch Handle different OS X paths (obsolete) — Splinter Review
Please let me know if there is a nicer way of handling this.
Attachment #8886257 - Flags: review?(cmanchester)
Summary: mach webrtc-gtest doesn't not work on mac → mach webrtc-gtest does not work on mac
Comment on attachment 8886257 [details] [diff] [review]
Handle different OS X paths

Review of attachment 8886257 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +1986,5 @@
> +        if self.substs['OS_ARCH'] == 'Darwin':
> +            app_path = os.path.join(self.distdir,
> +                                    self.substs['MOZ_MACBUNDLE_NAME'],
> +                                    'Contents', 'Resources', 'webrtc-gtest')
> +        else:

Should this actually be under Resources/, or MacOS/ ? If the latter, does putting 'webrtc-gtest' in browser/app/macbuild/Contents/MacOS-files.in help?
Attachment #8886257 - Flags: review?(cmanchester)
Yup, that is what I was looking for. Thanks!
Attachment #8886257 - Attachment is obsolete: true
Attachment #8886660 - Flags: review?(cmanchester)
Attachment #8886660 - Flags: review?(cmanchester) → review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3d08055513a
fix mach webrtc-gtest command on mac; r=chmanchester
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/e3d08055513a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.