1379982 - mach webrtc-gtest does not work on mac

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P3)

Description

[Dan Minor [:dminor]]

On mac, the webrtc.org gtests binary does not end up in the place where the mach command expects to find it.

Comment 1

[Dan Minor [:dminor]]

Attachment: Handle different OS X paths

Please let me know if there is a nicer way of handling this.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8886257 [details] [diff] [review]
Handle different OS X paths

Review of attachment 8886257 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +1986,5 @@
> +        if self.substs['OS_ARCH'] == 'Darwin':
> +            app_path = os.path.join(self.distdir,
> +                                    self.substs['MOZ_MACBUNDLE_NAME'],
> +                                    'Contents', 'Resources', 'webrtc-gtest')
> +        else:

Should this actually be under Resources/, or MacOS/ ? If the latter, does putting 'webrtc-gtest' in browser/app/macbuild/Contents/MacOS-files.in help?

Comment 3

[Dan Minor [:dminor]]

Attachment: Add webrtc-gtest to MacOS-files.in

Yup, that is what I was looking for. Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e3d08055513a
fix mach webrtc-gtest command on mac; r=chmanchester

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e3d08055513a