1379997 - MS-IME input mode notification stops working on Windows10 Creators Update

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: MS-IME input mode notification stops working

Reproducible: always

Steps To Reproduce:
1. Enable MS-IME
2. Toggle input mode from ひらがな　to 直接入力 and vice versa


Actual Results:
No notification pops up at the center of screen

IME mode Notification[あ]/[A] should popup at the center of screen


Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=38e06c672764234f76bd25fb482b58c640f09e1b&tochange=fd35e2ebf019d75c648d8ec5663bf58f1a444621

Regressed by: fd35e2ebf019	Masayuki Nakano — Bug 1367692 - Make IMEHandler not restore default IMC unless legacy IMM-IME is active. r=m_kato

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, thanks. So, disassociating IMC from the window hits a bug of TSF or MS-IME. We should disable the fix with pref.

Comment 3

[Gerry Chang [:gchang]]

Track 55+/56+ as regression in MS-IME input mode notification.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1379997 - part1: Disable "intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" pref in default settings

"intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" setting was implemented for *trying* to prevent crash bug of MS-IME on Creators Update.  However, according to the crash reports, this hack just changed the timing of crash and failed to reduce the rate.

Additionally, this causes to show another bug of MS-IME for Japanese.  That is, MS-IME for Japanese doesn't show current input mode with its popup when focus is moving from another application or changing current input mode.  This is annoying for MS-IME Japanese users.

Therefore, we should turn the pref off in default settings.

Review commit: https://reviewboard.mozilla.org/r/163070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163070/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1379997 - part2: Remove "intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" pref completely

"intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" should be unnecessary anymore because it failed to avoid the crash of MS-IME for Japanese but causing other regression.  Therefore, this patch removes it completely.

Review commit: https://reviewboard.mozilla.org/r/163072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163072/

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that only part1 should be uplifted if it's possible (for risk management).

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=078f545e02d6bf63c07469a0ab72d7eb289ea48e

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b206c1198f6dfa63a8aa5ea3635941e7f429d664

Comment 9

[Makoto Kato [:m_kato]]

Comment on attachment 8892059 [details]
Bug 1379997 - part1: Disable "intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" pref in default settings

https://reviewboard.mozilla.org/r/163070/#review168570

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8892060 [details]
Bug 1379997 - part2: Remove "intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" pref completely

https://reviewboard.mozilla.org/r/163072/#review168572

We need investigate CTipFnHotkeyManager related crash with MS team ...

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Makoto Kato [:m_kato] from comment #10)
> We need investigate CTipFnHotkeyManager related crash with MS team ...

I heard that this crash has already been fixed at Build 16215 (will be in Fall Creators Update, won't be ported to Creators Update, though).

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c312f2c6e58
part1: Disable "intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" pref in default settings r=m_kato
https://hg.mozilla.org/integration/autoland/rev/1b823be2a09f
part2: Remove "intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" pref completely r=m_kato

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5c312f2c6e58
https://hg.mozilla.org/mozilla-central/rev/1b823be2a09f

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8892059 [details]
Bug 1379997 - part1: Disable "intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" pref in default settings

Approval Request Comment
[Feature/Bug causing the regression]:
Regression of bug 1367692 (Although, this is also a bug of MS-IME for Japanese, and I've already reported this bug to them and confirmed by them).

[User impact if declined]:
Cannot see input mode with popup.

[Is this code covered by automated tests?]:
No.

[Has the fix been verified in Nightly?]:
Not yet, it'll be included in next build.

[Needs manual test from QE? If yes, steps to reproduce]:
No.

[List of other uplifts needed for the feature/fix]:
No.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
This patch just disables the hack added by bug 1367692. Note that the hack failed to avoid the crash of MS-IME for Japanese. And the crash report rate isn't changed. So, we can just disable the hack by this pref change.

[String changes made/needed]:
No.

Comment 15

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We don't need to uplift part2 since it removes the hack and pref but we don't need to do it in the branches.

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 8892059 [details]
Bug 1379997 - part1: Disable "intl.tsf.hack.ms_japanese_ime.do_not_associate_imc_on_win10" pref in default settings

ok let's take this one patch for 55 build2

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/153d1754c533

Comment 18

[Cornel Ionce [:noni] [Hubs QA]]

No need for manual testing based on comment 14. Setting qe-verify-

Comment 19

[Ryan VanderMeulen [:RyanVM]]

I have a hard time imagining that this issue is severe enough for our ESR52 user population to warrant backport consideration there. Feel free to set it back to affected and nominate for approval if you feel otherwise, though.

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #19)
> I have a hard time imagining that this issue is severe enough for our ESR52
> user population to warrant backport consideration there. Feel free to set it
> back to affected and nominate for approval if you feel otherwise, though.

If only small number of Japanese users use ESR52, it's not problem. Otherwise, I still think that we should disable the new hack by the pref. It might be annoying for MS-IME for Japanese users. First, IME has "open/closed" state. That is changed with "Hankaku/Zenkaku" key or Alt + '`' key. So, it's toggled by a key (combination). Users can confirm if the state is changed to expected "open/closed" state with the notification. In other words, when user type a character, users may realize that the state is unexpected after toggling the state. So, this may be annoying.