1380017 - Disallow non-e10s extensions

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[Andy McKay]

Let's ensure that if you are writing an extension using legacy technologies, its e10s friendly. Since e10s can be turned off on Nightly, we should make this flag turn offable on Nightly too.

The main point of this is to ensure that someone who writes a legacy add-on and signs it internally, doesn't ship something accidentally that isn't marked explicitly as e10s compatible.

Comment 1

[Andrew Swan [:aswan]]

Remind me how this is different from bug 1356027?

Comment 2

[Andy McKay]

Sorry, wasn't too clear. But when we discussed bug 1356027 it only applied to Nightly and was flippable (if I remember correctly). I think if I have internally signed bootstrapped extension I could run it on Beta or Release without it being multi-process compatible.

Comment 3

[Andrew Swan [:aswan]]

(In reply to Andy McKay [:andym] from comment #2)
> Sorry, wasn't too clear. But when we discussed bug 1356027 it only applied
> to Nightly and was flippable (if I remember correctly). I think if I have
> internally signed bootstrapped extension I could run it on Beta or Release
> without it being multi-process compatible.

I don't mean to be cheeky but why don't we just not internally sign non-MPC extensions?
We can't completely remove non-MPC support until bug 1351512 gets resolved.
At that point, we can just remove shims and all the MPC logic from the addons manager, but until then it doesn't seem paticularly useful to put any more work into this.

Comment 4

[Andy McKay]

That's also a fair point, I'll file a bug on the signing service to prevent that.

Comment 5

[Andy McKay]

https://github.com/mozilla-services/sign-xpi/issues/16

Comment 6

[Andy McKay]

I'm fine to close this in favour of the signing fix.