Closed
Bug 1380062
Opened 7 years ago
Closed 7 years ago
Sync locally deleted remote Mobile Bookmarks children
Categories
(Firefox for iOS :: Sync, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: eoger, Assigned: eoger)
References
(Blocks 1 open bug)
Details
(Whiteboard: [MobileCore][BookmarkSync][Sync Q3 OKR])
Attachments
(1 file)
There's two components to this bug: - We should allow bookmarks deletion in the UI inside the Mobile Bookmarks folder. - We should sync these deletions by keeping a tombstone around and uploading it later.
Comment 1•7 years ago
|
||
I discussed this briefly with Mark and others at the San Francisco work week, but: Once a bookmark has made it to the server and left the local bookmarks table, there's really no difference between a mobile bookmark and any other bookmark. (And there's no difference between the Mobile Bookmarks folder and any other: it's ordered, can contain folders, can have records moved in and out.) What _is_ plausible is: - We know for each buffer bookmark if it has a single parent. - We know if its parent pointer and its parent's child pointer agree. If so, we can allow for a direct deletion that uploads two changed records (the bookmark and its parent folder). There's no reason to limit this to direct children of the Mobile Bookmarks folder.
Updated•7 years ago
|
Whiteboard: [MobileCore][BookmarkSync]
Assignee | ||
Updated•7 years ago
|
Summary: Allow bookmarks deletion in Mobile Bookmarks and sync it → Sync locally deleted Mobile Bookmarks children
Updated•7 years ago
|
Hardware: Other → All
Summary: Sync locally deleted Mobile Bookmarks children → Sync locally deleted remote Mobile Bookmarks children
Assignee | ||
Comment 2•7 years ago
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8893892 [details] [review] mozilla-mobile/firefox-ios#2995 Squashed and landed: https://github.com/mozilla-mobile/firefox-ios/commit/529fb6a46103f9a30593145a63be4a06df15bb0d
Attachment #8893892 -
Flags: review?(rnewman) → review+
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Whiteboard: [MobileCore][BookmarkSync] → [MobileCore][BookmarkSync][Sync Q3 OKR]
You need to log in
before you can comment on or make changes to this bug.
Description
•