Check Stylo env var in test manifest processing

RESOLVED FIXED in Firefox 56

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

(Assignee)

Description

8 months ago
We need update reftests, WPT, mochitest, etc. to check STYLO_FORCE_ENABLED when deciding which tests to run.
(Assignee)

Comment 1

8 months ago
First attempt:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a737af0e9caea55ee120e6cda15125607a87ee5e

WPT is working now, but mochitest and reftests still don't seem to have the right Stylo status.
(Assignee)

Comment 2

8 months ago
Getting closer, I believe mochitest is correct now.  Added some logging for reftest.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c441af585dccc8d26f5ffc92c0d5acdf567a198
(Assignee)

Comment 3

8 months ago
Some tests check the Stylo pref for enabled status, so it's easier to have the env var set the pref.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fecd087a83b4de4c4f1ad51a5d9e8c879a05769b
(Assignee)

Comment 4

8 months ago
Setting the pref from C++ didn't go well, but we can update tests to check the `isStyledByServo` property.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=159762f8cd3d166f5b476f2ca9d9a8e9b0bb230b
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

8 months ago
mozreview-review
Comment on attachment 8885930 [details]
Bug 1380082 - Don't Stylo check pref directly in tests.

https://reviewboard.mozilla.org/r/156720/#review161858
Attachment #8885930 - Flags: review?(xidorn+moz) → review+
Attachment #8885927 - Flags: review?(xidorn+moz) → review?(jmaher)

Comment 11

8 months ago
mozreview-review
Comment on attachment 8885928 [details]
Bug 1380082 - Check Stylo env var for mochitest processing.

https://reviewboard.mozilla.org/r/156716/#review162022
Attachment #8885928 - Flags: review?(ahalberstadt) → review+

Comment 12

8 months ago
mozreview-review
Comment on attachment 8885927 [details]
Bug 1380082 - Check Stylo env var for reftest processing.

https://reviewboard.mozilla.org/r/156714/#review162052

nice and simple
Attachment #8885927 - Flags: review?(jmaher) → review+

Comment 13

8 months ago
mozreview-review
Comment on attachment 8885929 [details]
Bug 1380082 - Check Stylo env var for WPT processing.

https://reviewboard.mozilla.org/r/156718/#review162592
Attachment #8885929 - Flags: review?(james) → review+

Comment 14

8 months ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/94ab7d2d377a
Check Stylo env var for reftest processing. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/c6a937ceb496
Check Stylo env var for mochitest processing. r=ahal
https://hg.mozilla.org/integration/autoland/rev/9bdcd7d00ed6
Check Stylo env var for WPT processing. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/8b7a40e98c28
Don't Stylo check pref directly in tests. r=xidorn

Comment 15

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/94ab7d2d377a
https://hg.mozilla.org/mozilla-central/rev/c6a937ceb496
https://hg.mozilla.org/mozilla-central/rev/9bdcd7d00ed6
https://hg.mozilla.org/mozilla-central/rev/8b7a40e98c28
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.