1380087 - Add IsMapObject and IsSetObject intrinsic for self-hosted code

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement)

Description

[André Bargull [:anba]]

So we don't need to call Map|Set.prototype.has within a try-catch block.


Improves this µ-benchmark from 270ms to ~160ms (*) for me:

    var s = new Set(Array(100).fill(0).map((v, k) => k + 1));
    var q = 0;
    function fn() { ++q; }
    var t = Date.now();
    for (var i = 0; i < 100000; ++i) {
        s.forEach(fn);
    }
    print(Date.now() - t, q);


(*) Interestingly I also get ~160ms when testing with v8/jsc/chakra!

Comment 1

[André Bargull [:anba]]

Attachment: bug1380087.patch

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8885399 [details] [diff] [review]
bug1380087.patch

Review of attachment 8885399 [details] [diff] [review]:
-----------------------------------------------------------------

Huh, I had forgotten about these ugly hacks :( Thank you for fixing them.

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cff2827909ce0abd19b1968ed7ffcf941469cd1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e27c8cad5d1
Add an intrinsic to test for Map and Set objects. r=till

Comment 5

[Carsten Book [:Tomcat]]

backed this out in https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=0e71e43dcee8655ce22cb3ad2cef44e17e06fea7&filter-searchStr=Linux+debug+Xpcshell+tests+executed+by+TaskCluster+test-linux32%2Fdebug-xpcshell-6+tc-X(X6) because of xpc x6 failures like https://treeherder.mozilla.org/logviewer.html#?job_id=113972672&repo=autoland which are still occur after the backout of bug 1379983

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/812f0d47226f
Backed out changeset 4e27c8cad5d1

Comment 7

[André Bargull [:anba]]

The latests try (https://treeherder.mozilla.org/#/jobs?repo=try&revision=baaf2d8b31d38b5fc5d32fdec94dc884673bc770) didn't show any failures in test_available_free_space.js, so I guess it's one of these known intermittent bugs (bug 1368219, bug 1380607, bug 1378088), therefore requesting checkin-needed again.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ff407adc162
Add an intrinsic to test for Map and Set objects. r=till

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ff407adc162