If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Pref and Autoconfig modules should build based on OS_ARCH not MOZ_WIDGET_TOOLKIT

RESOLVED FIXED in Firefox 40

Status

()

Core
Preferences: Backend
P5
minor
RESOLVED FIXED
16 years ago
2 years ago

People

(Reporter: Brian Nesse (gone), Assigned: mkaply)

Tracking

Trunk
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

16 years ago
This was spun out of bug 132140. Right now the backend prefs library, and the
autoconfig library which was hatched from it, both build based off the
MOZ_WIDGET_TOOLKIT define. As these libraries are totally independent of the
tookit they should really be built based on the OS_ARCH define instead. cc'ing
the people who originally pointed this out, as well as seawood who was suggested
as "the person who understands the build system" ;)
Assignee: bnesse → nobody
QA Contact: bugzilla → preferences-backend
(Assignee)

Comment 1

6 years ago
This is actually still a bug as shocking as that is

http://mxr.mozilla.org/mozilla-central/source/extensions/pref/autoconfig/src/Makefile.in#72
(Assignee)

Updated

6 years ago
Assignee: nobody → mozilla
(Assignee)

Comment 2

5 years ago
So upon further review, I think we should just remove all of these platform.js files.

They seem unnecessary.

They are used to set a "platform.value" global which I assume could be used by an autoconfig to do platform stuff, but it was never documented and there are much better ways to detect the platform.

Updated

5 years ago
Priority: -- → P5
(Assignee)

Comment 3

3 years ago
Created attachment 8591070 [details]
MozReview Request: bz://138009/mkaply

/r/6923 - Bug 138009 - Remove unused platform.js

Pull down this commit:

hg pull -r 53f5ff9a7033f37beee87f8866012e7645d25627 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8591070 - Flags: review?(benjamin)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8591070 [details]
MozReview Request: bz://138009/mkaply

/r/6923 - Bug 138009 - Remove unused platform.js

Pull down this commit:

hg pull -r 53f5ff9a7033f37beee87f8866012e7645d25627 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8591070 - Flags: review?(benjamin) → review?(dtownsend)
(Assignee)

Comment 5

3 years ago
I decided to just completely remove the platform stuff.

I have never documented it and I search everywhere and can find no reference to it.
Comment on attachment 8591070 [details]
MozReview Request: bz://138009/mkaply

https://reviewboard.mozilla.org/r/6921/#review5977

Ship It!
Attachment #8591070 - Flags: review?(dtownsend) → review+

Comment 7

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d38346a423b5
Backed out for bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/95999fe8a720

https://treeherder.mozilla.org/logviewer.html#?job_id=8999598&repo=mozilla-inbound
(Assignee)

Comment 9

3 years ago
no idea how I missed that.

Comment 10

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8135b5939fae
https://hg.mozilla.org/mozilla-central/rev/8135b5939fae
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
(Assignee)

Comment 12

2 years ago
Created attachment 8617906 [details]
MozReview Request: Bug 138009 - Remove unused platform.js
Comment on attachment 8617906 [details]
MozReview Request: Bug 138009 - Remove unused platform.js

Sorry for the spam; MozReview-attachment script was executed incorrectly.
Attachment #8617906 - Attachment is obsolete: true
(Assignee)

Comment 14

2 years ago
Comment on attachment 8591070 [details]
MozReview Request: bz://138009/mkaply
Attachment #8591070 - Attachment is obsolete: true
Attachment #8617968 - Flags: review+
(Assignee)

Comment 15

2 years ago
Created attachment 8617968 [details]
MozReview Request: Bug 138009 - Remove unused platform.js
You need to log in before you can comment on or make changes to this bug.