138009 - Pref and Autoconfig modules should build based on OS_ARCH not MOZ_WIDGET_TOOLKIT

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect, P5)

Description

[Brian Nesse (gone)]

This was spun out of bug 132140. Right now the backend prefs library, and the
autoconfig library which was hatched from it, both build based off the
MOZ_WIDGET_TOOLKIT define. As these libraries are totally independent of the
tookit they should really be built based on the OS_ARCH define instead. cc'ing
the people who originally pointed this out, as well as seawood who was suggested
as "the person who understands the build system" ;)

Comment 1

[Mike Kaply [:mkaply]]

This is actually still a bug as shocking as that is

http://mxr.mozilla.org/mozilla-central/source/extensions/pref/autoconfig/src/Makefile.in#72

Comment 2

[Mike Kaply [:mkaply]]

So upon further review, I think we should just remove all of these platform.js files.

They seem unnecessary.

They are used to set a "platform.value" global which I assume could be used by an autoconfig to do platform stuff, but it was never documented and there are much better ways to detect the platform.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: MozReview Request: bz://138009/mkaply

/r/6923 - Bug 138009 - Remove unused platform.js

Pull down this commit:

hg pull -r 53f5ff9a7033f37beee87f8866012e7645d25627 https://reviewboard-hg.mozilla.org/gecko/

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8591070 [details]
MozReview Request: bz://138009/mkaply

/r/6923 - Bug 138009 - Remove unused platform.js

Pull down this commit:

hg pull -r 53f5ff9a7033f37beee87f8866012e7645d25627 https://reviewboard-hg.mozilla.org/gecko/

Comment 5

[Mike Kaply [:mkaply]]

I decided to just completely remove the platform stuff.

I have never documented it and I search everywhere and can find no reference to it.

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8591070 [details]
MozReview Request: bz://138009/mkaply

https://reviewboard.mozilla.org/r/6921/#review5977

Ship It!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d38346a423b5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/95999fe8a720

https://treeherder.mozilla.org/logviewer.html#?job_id=8999598&repo=mozilla-inbound

Comment 9

[Mike Kaply [:mkaply]]

no idea how I missed that.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8135b5939fae

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8135b5939fae

Comment 12

[Mike Kaply [:mkaply]]

Attachment: MozReview Request: Bug 138009 - Remove unused platform.js

Comment 13

[Mark Côté [:mcote]]

Comment on attachment 8617906 [details]
MozReview Request: Bug 138009 - Remove unused platform.js

Sorry for the spam; MozReview-attachment script was executed incorrectly.

Comment 15

[Mike Kaply [:mkaply]]

Attachment: MozReview Request: Bug 138009 - Remove unused platform.js