Closed Bug 138009 Opened 18 years ago Closed 5 years ago

Pref and Autoconfig modules should build based on OS_ARCH not MOZ_WIDGET_TOOLKIT

Categories

(Core :: Preferences: Backend, defect, P5, minor)

defect

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: bnesse, Assigned: mkaply)

Details

Attachments

(1 file, 2 obsolete files)

This was spun out of bug 132140. Right now the backend prefs library, and the
autoconfig library which was hatched from it, both build based off the
MOZ_WIDGET_TOOLKIT define. As these libraries are totally independent of the
tookit they should really be built based on the OS_ARCH define instead. cc'ing
the people who originally pointed this out, as well as seawood who was suggested
as "the person who understands the build system" ;)
Assignee: bnesse → nobody
QA Contact: bugzilla → preferences-backend
Assignee: nobody → mozilla
So upon further review, I think we should just remove all of these platform.js files.

They seem unnecessary.

They are used to set a "platform.value" global which I assume could be used by an autoconfig to do platform stuff, but it was never documented and there are much better ways to detect the platform.
Priority: -- → P5
Attached file MozReview Request: bz://138009/mkaply (obsolete) —
/r/6923 - Bug 138009 - Remove unused platform.js

Pull down this commit:

hg pull -r 53f5ff9a7033f37beee87f8866012e7645d25627 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8591070 - Flags: review?(benjamin)
Comment on attachment 8591070 [details]
MozReview Request: bz://138009/mkaply

/r/6923 - Bug 138009 - Remove unused platform.js

Pull down this commit:

hg pull -r 53f5ff9a7033f37beee87f8866012e7645d25627 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8591070 - Flags: review?(benjamin) → review?(dtownsend)
I decided to just completely remove the platform stuff.

I have never documented it and I search everywhere and can find no reference to it.
Comment on attachment 8591070 [details]
MozReview Request: bz://138009/mkaply

https://reviewboard.mozilla.org/r/6921/#review5977

Ship It!
Attachment #8591070 - Flags: review?(dtownsend) → review+
no idea how I missed that.
https://hg.mozilla.org/mozilla-central/rev/8135b5939fae
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8617906 [details]
MozReview Request: Bug 138009 - Remove unused platform.js

Sorry for the spam; MozReview-attachment script was executed incorrectly.
Attachment #8617906 - Attachment is obsolete: true
Attachment #8591070 - Attachment is obsolete: true
Attachment #8617968 - Flags: review+
You need to log in before you can comment on or make changes to this bug.