Closed Bug 1380110 Opened 7 years ago Closed 7 years ago

--disable-sandbox broken in toolkit/xre/nsAppRunner.cpp

Categories

(Core :: Security: Process Sandboxing, enhancement)

Product:
Core
Component:
Security: Process Sandboxing
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: tjr, Assigned: tjr)

Details

(Whiteboard: sb+)

Attachments

(1 file)

Bug 1380110 Fix --disable-sandbox by adding #if guards
59 bytes, text/x-review-board-request
handyman
: review+
bobowen
: review+
Details 
Added a couple of lines without the if guard.
Comment on attachment 8885416 [details]
Bug 1380110 Fix --disable-sandbox by adding #if guards

https://reviewboard.mozilla.org/r/156264/#review161486

Its definitely missing the preprocessor directives but these should be MOZ_SANDBOX, not MOZ_CONTENT_SANDBOX.  r+ with that change.
Attachment #8885416 - Flags: review?(davidp99) → review+
This doesn't meet the review requirements in MozReview for Autoland to push it.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits
Keywords: checkin-needed
Flags: needinfo?(tom)
Whiteboard: sb+
Comment on attachment 8885416 [details]
Bug 1380110 Fix --disable-sandbox by adding #if guards

https://reviewboard.mozilla.org/r/156264/#review162082
Attachment #8885416 - Flags: review+
Comment on attachment 8885416 [details]
Bug 1380110 Fix --disable-sandbox by adding #if guards

https://reviewboard.mozilla.org/r/156264/#review162086
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5f2d5cf0714f
Fix --disable-sandbox by adding #if guards r=bobowen,handyman
https://hg.mozilla.org/mozilla-central/rev/5f2d5cf0714f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Flags: needinfo?(tom)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: