1380111 - Inline iterator code into Map/Set.prototype.forEach

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement)

Description

[André Bargull [:anba]]

With bug 1380087, this patch seems to improve Map.prototype.forEach quite a bit.


Improves from 480ms (tip) to 150ms:

    var m = new Map(Array(100).fill(0).map((v, k) => [k + 1, null]));
    var q = 0;
    function fn(v, k) { q += k; }
    var t = Date.now();
    for (var i = 0; i < 100000; ++i) {
        m.forEach(fn);
    }
    print([Date.now() - t, q);



Improves from 160ms (bug 1380087) to 130ms for me:

    var s = new Set(Array(100).fill(0).map((v, k) => k + 1));
    var q = 0;
    function fn() { ++q; }
    var t = Date.now();
    for (var i = 0; i < 100000; ++i) {
        s.forEach(fn);
    }
    print(Date.now() - t, q);

Comment 1

[André Bargull [:anba]]

Attachment: bug1380111.patch

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8885418 [details] [diff] [review]
bug1380111.patch

Review of attachment 8885418 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, r=me

::: js/src/builtin/Set.js
@@ +37,5 @@
>      var values = callFunction(std_Set_iterator, S);
> +
> +    // Inlined: SetIteratorNext
> +    var setIterationResult = setIteratorTemp.setIterationResult;
> +    if (!setIterationResult) {

style nit: no braces needed

Comment 3

[André Bargull [:anba]]

Attachment: bug1380111.patch

Addressed review comments, carrying r+.

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3cff2827909ce0abd19b1968ed7ffcf941469cd1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bed95eec1188
Inline iterator code into Map/Set forEach to avoid extra allocations. r=till

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bed95eec1188