138012 - 3-5% regression on window open (txul)

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Cathleen]

comet:
txul 469 -> 481 (2.55%)
http://bonsai.mozilla.org/cvsquery.cgi?module=MozillaTinderboxAll&date=explicit&mindate=1019014980&maxdate=1019017019
http://bonsai.mozilla.org/cvsquery.cgi?module=MozillaTinderboxAll&date=explicit&mindate=1019017020&maxdate=1019018879

sleekstack:
1752 -> 1855  (5.87%)
http://bonsai.mozilla.org/cvsquery.cgi?module=MozillaTinderboxAll&date=explicit&mindate=1019016840&maxdate=1019020799

mecca 2057 -> 2168  (5.39%)
http://bonsai.mozilla.org/cvsquery.cgi?module=MozillaTinderboxAll&date=explicit&mindate=1019013900&maxdate=1019018219

assign to jst.

Comment 1

[Chris McAfee]

adding varada for mailnews leak on lhasa/testerbox
(10.9k -> 12k)

refcnt leak to 4.8 -> 5.7 on brad.

Comment 2

[Johnny Stenback (:jst)]

Attachment: Proposed fix

Comment 3

[Cathleen]

Johnny, i tried your patch, but mozilla dumps core on my build.  
i went through all the files and made sure patch was applied and new file added.
clobbered layout and then content, but nothing worked.

i'm putting box back online now.  we'll have to try again tomorrow.

Comment 4

[rbs]

did you try jst's patch with a tree-wide depend build?

Comment 5

[Cathleen]

on friday 4/19, after applying jst's patch, txul went from 1912 down to 1759

Comment 6

[Peter Van der Beken [:peterv]]

After applying this patch, when the first window is opened it doesn't have a
white background (as if about:blank isn't layed out correctly).

Comment 7

[Johnny Stenback (:jst)]

Attachment: Better, smaller and faster diff, I think...

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 80774 [details] [diff] [review]
Better, smaller and faster diff, I think...

>Index: content/base/src/nsFrameLoader.cpp
>===================================================================
...
>@@ -147,7 +144,7 @@
> nsFrameLoader::LoadFrame()
> {
>   NS_ENSURE_TRUE(mOwnerContent, NS_ERROR_NOT_INITIALIZED);
>-
>+ 

Don't add a space

r=peterv

Comment 9

[jag (Peter Annema)]

Comment on attachment 80774 [details] [diff] [review]
Better, smaller and faster diff, I think...

sr=jag

Comment 10

[Johnny Stenback (:jst)]

Fix checked in.