Add a pref to enable the D3D11 Debug Layer

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

If we enabled this in a pref it would be easier to request debug layer feedback from users experiencing graphics issues.
Comment on attachment 8885446 [details]
Bug 1380142: Add a pref to enable the D3D11 debug layer and to break on errors.

https://reviewboard.mozilla.org/r/156302/#review161476

::: modules/libpref/init/all.js:4823
(Diff revision 1)
>  
>  // Whether to attempt to enable Direct2D regardless of automatic detection or
>  // blacklisting
>  pref("gfx.direct2d.force-enabled", false);
>  
> +pref("gfx.direct3d11.enable-debug-layer", false);

I don't feel strongly one way or the other, but we may not want to put these in the all.js, and just have people type in the name in about:config.
Attachment #8885446 - Flags: review?(milan) → review+
(In reply to Milan Sreckovic [:milan] from comment #2)
> Comment on attachment 8885446 [details]
> Bug 1380142: Add a pref to enable the D3D11 debug layer and to break on
> errors.
> 
> https://reviewboard.mozilla.org/r/156302/#review161476
> 
> ::: modules/libpref/init/all.js:4823
> (Diff revision 1)
> >  
> >  // Whether to attempt to enable Direct2D regardless of automatic detection or
> >  // blacklisting
> >  pref("gfx.direct2d.force-enabled", false);
> >  
> > +pref("gfx.direct3d11.enable-debug-layer", false);
> 
> I don't feel strongly one way or the other, but we may not want to put these
> in the all.js, and just have people type in the name in about:config.

Yeah, I was thinking about this, I figured if we expected support people to use this, and since there's no obvious way of being sure this worked while running Firefox. It might reduce the workload and opportunity for mistakes if I put it in there.
Assignee: nobody → bas
Status: NEW → ASSIGNED
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a2bc58d4298
Add a pref to enable the D3D11 debug layer and to break on errors. r=milan
https://hg.mozilla.org/mozilla-central/rev/1a2bc58d4298
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.